On Thu, Jul 07, 2016 at 01:06:31PM +0200, Lukas Slebodnik wrote:
On (07/07/16 13:05), Pavel Březina wrote:
>On 06/30/2016 03:37 PM, Lukas Slebodnik wrote:
>> On (30/06/16 09:28), Sumit Bose wrote:
>> > On Wed, Jun 29, 2016 at 11:23:55PM +0200, Jakub Hrozek wrote:
>> > > Hi,
>> > > I pushed the attached patch under the one-liner rule (which I'm
>> > > big fan of, but it's late and I've been wanting to do this
>> > > almost a week..)
>> > >
>> > > I hope it's OK with everybody. I added a silly RB to satisfy our
>> > > hook.
>> > Thank you for catching this. The patch makes sense and looks good by
>> > careful visual inspection. So afterwards-ACK.
>> > bye,
>> > Sumit
>> > > From 1dab34228cefddcd6bedef2d2cee70a620c8ace8 Mon Sep 17 00:00:00
>> > > From: Jakub Hrozek <jhrozek(a)redhat.com>
>> > > Date: Wed, 29 Jun 2016 23:16:54 +0200
>> > > Subject: [PATCH] MAN: Include idmap_sss.8.xml in the manpage sources
>> > >
>> > > Reviewed-by: N/A, one-liner before release
>> > > ---
>> > > src/man/po/po4a.cfg | 1 +
>> > > 1 file changed, 1 insertion(+)
>> > >
>> > > diff --git a/src/man/po/po4a.cfg b/src/man/po/po4a.cfg
>> > > index
>> > > --- a/src/man/po/po4a.cfg
>> > > +++ b/src/man/po/po4a.cfg
>> > > @@ -26,6 +26,7 @@
>> > > [type:docbook] sss_rpcidmapd.5.xml
>> > > [type:docbook] sss_ssh_authorizedkeys.1.xml
>> > > [type:docbook] sss_ssh_knownhostsproxy.1.xml
>> > > +[type:docbook] idmap_sss.8.xml
>> > > [type:docbook] include/service_discovery.xml
$lang:$(builddir)/$lang/include/service_discovery.xml opt:"-k 0"
>> > > [type:docbook] include/upstream.xml
$lang:$(builddir)/$lang/include/upstream.xml opt:"-k 0"
>> > > [type:docbook] include/failover.xml
$lang:$(builddir)/$lang/include/failover.xml opt:"-k 0"
>> > > --
>> > > 2.4.11
>> > >
>> It happened more time that we forgot to add man page there.
>> Maybe it would be good to write a test. (bash script should be enough)
>> We already have a test to check traling whitestapces
>Instead of writing a test, it would be better to write a script to generate
That's good idea as well.
I know we tried it in the past, but there was an issue generatingn the
file with parallel build. But maybe we didn't try hard enough.