On Fri, Jul 10, 2015 at 05:48:57PM +0200, Sumit Bose wrote:
Hi,
this patch fixes a simple copy-and-paste issue in the common test code.
Since we currently always call mock_account_recv() with the second and
third argument set to 0 and NULL respectively it doesn't became an issue
earlier.
bye,
Sumit
From 5d2a8ee6d6d26d276b3be4c97fe0bf9e5cf7d099 Mon Sep 17 00:00:00
2001
From: Sumit Bose <sbose(a)redhat.com>
Date: Fri, 10 Jul 2015 12:37:43 +0200
Subject: [PATCH] test common: sss_dp_get_account_recv() fix assignment
---
src/tests/cmocka/common_mock_resp_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tests/cmocka/common_mock_resp_dp.c
b/src/tests/cmocka/common_mock_resp_dp.c
index 08d74179d8e2dc0561ea3e2d1e9b5580762ee633..a67ceee4a43184d9894c19a5c11161aca4e1caff
100644
--- a/src/tests/cmocka/common_mock_resp_dp.c
+++ b/src/tests/cmocka/common_mock_resp_dp.c
@@ -51,7 +51,7 @@ sss_dp_get_account_recv(TALLOC_CTX *mem_ctx,
*dp_err = sss_mock_type(dbus_uint16_t);
*dp_ret = sss_mock_type(dbus_uint32_t);
- *dp_ret = sss_mock_type(dbus_uint32_t);
+ *err_msg = sss_mock_ptr_type(char *);
(Spoiler alert: Sumit already showed me the bug on IRC)
ACK.
CI:
http://sssd-ci.duckdns.org/logs/job/18/78/summary.html