On Fri, Jan 09, 2015 at 10:57:45AM +0100, Lukas Slebodnik wrote:
glustefs, libvirtd use the same aproach with delaycompress for log files.
Simple patch is attached.
From 60747736361479fb372ebf4e97477ce0bd6dbced Mon Sep 17 00:00:00
From: Lukas Slebodnik <lslebodn(a)redhat.com>
Date: Fri, 9 Jan 2015 10:50:59 +0100
Subject: [PATCH] logrotate: Fix warning file size changed while zipping
Postpone compression of the previous log file to the next rotation cycle.
This only has effect when used in combination with compress. We need to use it
because we cannot tell sssd to close log files and thus sssd processes might
continue writing to the previous log file for some time.
src/examples/logrotate | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/examples/logrotate b/src/examples/logrotate
@@ -5,6 +5,7 @@
/bin/kill -HUP `cat /var/run/sssd.pid 2>/dev/null` 2> /dev/null || true
Makes sense. Also from logrotate man page:
Postpone compression of the previous log file to the next rotation
cycle. This only has effect when used in combination with compress. It can be used when
program cannot be told to close its logfile and thus might continue writing
to the previous log file for some time.
So keeping both compress and delaycompress is correct.