URL: https://github.com/SSSD/sssd/pull/554 Author: jhrozek Title: #554: Several fixes for the files provider Action: opened
PR body: """ This PR contains several fixes for the files provider, mainly a performance bug which is really embarassing - I have no idea why was the code #if-ed out. I think I must have been experimenting with the provider update and then forgot to remove the preprocessor macros. The rest is mostly code cleanup and minor fixes.
btw initially I wanted to also include a fix to avoid removing cachedPassword on updates, but I realized the current way where the files provider throws away everything and then updates everything would force us to maintain all the sssd-added attributes on our own. And because especially with 2FA it might not be just cachedPassword, but also the factor length or offline lockout counter etc, we might as well devise a better way to update the cache than just throw away everything and recreate the entries, so I'll work on that separately. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/554/head:pr554 git checkout pr554
URL: https://github.com/SSSD/sssd/pull/554 Title: #554: Several fixes for the files provider
fidencio commented: """ @jhrozek, there are some pep8 failures in those patches according to our internal CI. """
See the full comment at https://github.com/SSSD/sssd/pull/554#issuecomment-382371386
URL: https://github.com/SSSD/sssd/pull/554 Title: #554: Several fixes for the files provider
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/554 Title: #554: Several fixes for the files provider
jhrozek commented: """ btw I'll leave the patches around for a bit because I'm working on another fixes for the files provider and I'd like to make sure the patches relate and we don't end up rewriting these in the next patchset. """
See the full comment at https://github.com/SSSD/sssd/pull/554#issuecomment-382672876
URL: https://github.com/SSSD/sssd/pull/554 Author: jhrozek Title: #554: Several fixes for the files provider Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/554/head:pr554 git checkout pr554
URL: https://github.com/SSSD/sssd/pull/554 Title: #554: Several fixes for the files provider
jhrozek commented: """ Actually, I will work on the other enhancements which involve not flushing all the data all the time later, so I updated the PR now with the pep8 and indentation fixes. """
See the full comment at https://github.com/SSSD/sssd/pull/554#issuecomment-384570955
URL: https://github.com/SSSD/sssd/pull/554 Title: #554: Several fixes for the files provider
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/554 Title: #554: Several fixes for the files provider
pbrezina commented: """ Ack. Thank you. """
See the full comment at https://github.com/SSSD/sssd/pull/554#issuecomment-384592000
URL: https://github.com/SSSD/sssd/pull/554 Title: #554: Several fixes for the files provider
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/554 Title: #554: Several fixes for the files provider
fidencio commented: """ master: d69e1da 1f8bfb6 81f1699 c1bce7d 77d63f5 """
See the full comment at https://github.com/SSSD/sssd/pull/554#issuecomment-384950049
URL: https://github.com/SSSD/sssd/pull/554 Author: jhrozek Title: #554: Several fixes for the files provider Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/554/head:pr554 git checkout pr554
URL: https://github.com/SSSD/sssd/pull/554 Title: #554: Several fixes for the files provider
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/554 Title: #554: Several fixes for the files provider
Label: +Pushed
sssd-devel@lists.fedorahosted.org