On Fri, 2012-04-27 at 12:54 +0200, Jakub Hrozek wrote:
On Thu, Apr 26, 2012 at 12:41:58PM +0200, Sumit Bose wrote:
> this patch extends the functionality of libidmap by allow more kind of
> SID representations, especially the binary format which is used e.g. to
> store SIDs in AD.
> I have added tests for all new functions, but mostly they only test the
> positve case and do not try to break anything with invalid inputs. Fell
> free to add more :-)
The code looks good to me, test pass and all the functions are covered
in the test suite.
Ack, provided that the interface works for Stephen.
Works fine for me. I've tested it with my patches (now on the list as
"[PATCHES] Add support for ID-mapping with Active Directory domains").