URL: https://github.com/SSSD/sssd/pull/816 Author: kernevil Title: #816: SUDO: Allow defaults sudoRole without sudoUser attribute Action: opened
PR body: """ Signed-off-by: Samuel Cabrero scabrero@suse.de """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/816/head:pr816 git checkout pr816
URL: https://github.com/SSSD/sssd/pull/816 Title: #816: SUDO: Allow defaults sudoRole without sudoUser attribute
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/816#issuecomment-493418166
URL: https://github.com/SSSD/sssd/pull/816 Title: #816: SUDO: Allow defaults sudoRole without sudoUser attribute
jhrozek commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/816#issuecomment-493439415
URL: https://github.com/SSSD/sssd/pull/816 Title: #816: SUDO: Allow defaults sudoRole without sudoUser attribute
jhrozek commented: """ @pbrezina can you review, please? """
See the full comment at https://github.com/SSSD/sssd/pull/816#issuecomment-493439461
URL: https://github.com/SSSD/sssd/pull/816 Title: #816: SUDO: Allow defaults sudoRole without sudoUser attribute
pbrezina commented: """ The code is pretty easy and it looks good. I just wonder when this problem have occurred? I did not find any recent changes that would triggered this change and yet we got two PRs for it at the same time.
@kernevil, @pzirnik Was this always an issue or did it happen after an upgrade to newer SSSD version? What was your previous version and what is your current version? Thank you. """
See the full comment at https://github.com/SSSD/sssd/pull/816#issuecomment-494284014
URL: https://github.com/SSSD/sssd/pull/816 Title: #816: SUDO: Allow defaults sudoRole without sudoUser attribute
pzirnik commented: """ commit f4a1046bb88d7a0ab3617e49ae94bfa849d10645 introduced the issue. In fact the issue was observed after updating from sssd 1.13 to 1.16 """
See the full comment at https://github.com/SSSD/sssd/pull/816#issuecomment-494293389
URL: https://github.com/SSSD/sssd/pull/816 Title: #816: SUDO: Allow defaults sudoRole without sudoUser attribute
pbrezina commented: """ This patch has been there since 2016 since sssd-1.14. So apparently it was revealed by your update from 1.13 to 1.16.
Ack to the patch.
Steps to reproduce: 1. Set `case_sensitive = false` 2. Add `cn=defaults` rule without `sudoUser` attribute 3. Check with `sudo -l` or with `ldbsearch` that it is not cached """
See the full comment at https://github.com/SSSD/sssd/pull/816#issuecomment-494724503
URL: https://github.com/SSSD/sssd/pull/816 Title: #816: SUDO: Allow defaults sudoRole without sudoUser attribute
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/816 Title: #816: SUDO: Allow defaults sudoRole without sudoUser attribute
jhrozek commented: """ * master: 10170fe683add7a71b3f03d11e485ea102c677bd * sssd-1-16: 2173201b5c998715e67e85beb96167e5ab6c2822 """
See the full comment at https://github.com/SSSD/sssd/pull/816#issuecomment-494935733
URL: https://github.com/SSSD/sssd/pull/816 Author: kernevil Title: #816: SUDO: Allow defaults sudoRole without sudoUser attribute Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/816/head:pr816 git checkout pr816
URL: https://github.com/SSSD/sssd/pull/816 Title: #816: SUDO: Allow defaults sudoRole without sudoUser attribute
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
centos-ci -
jhrozek
-
kernevil
-
pbrezina
-
pzirnik