Title: #56: Update dlopen test
On (25/10/16 00:36), celestian wrote:
celestian requested changes on this pull request.
I found one little nitpick (see inline comment).
And there is CI summary:
RPM build errors:
Empty %files file /builddir/build/BUILD/sssd-1.14.90/sssd_client.lang
File not found:
Child return code was: 1
Traceback (most recent call last):
File "/usr/lib/python3.5/site-packages/mockbuild/trace_decorator.py", line 89,
result = func(*args, **kw)
File "/usr/lib/python3.5/site-packages/mockbuild/util.py", line 569, in do
raise exception.Error("Command failed. See logs for output.\n # %s" %
mockbuild.exception.Error: Command failed. See logs for output.
# bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps
It seems it is not connected to your patch set.
Yes, it's fixed in PR#64
However, code LGTM.
> @@ -154,16 +155,84 @@ static bool recursive_dlopen(const char **name, int round, char
+static int file_so_filter(const struct dirent *ent)
Just a nitpick -- if function returns values 0 and 1 and it is answer to question of type
yes/no, isn't bool better than int?
because this function is used as a callback in scandir which
requires such prototype.
#see man 3 SCANDIR
See the full comment at https://github.com/SSSD/sssd/pull/56#issuecomment-255960749