jhrozek commented on a pull request
""" OK, also looking at gdb confirms this is the right fix of course:
(gdb) frame 0 #0 sdap_initgr_nested_get_membership_diff (mem_ctx=0x1176190, sysdb=0x1120040, opts=0x1134d90, dom=0x110b610, group=0x1184b80, all_groups=0x1184a80, groups_count=5, _mdiff=0x7ffe14f1ed38) at /sssd/src/providers/ldap/sdap_async_initgroups.c:1420 1420 opts->group_map[SDAP_AT_GROUP_NAME].name, (gdb) list 1415 1416 if (parents_count > 0) { 1417 ret = sysdb_attrs_primary_fqdn_list(dom, tmp_ctx, 1418 ldap_parentlist, 1419 parents_count, 1420 opts->group_map[SDAP_AT_GROUP_NAME].name, 1421 &ldap_parent_names_list); 1422 if (ret != EOK) { 1423 DEBUG(SSSDBG_CRIT_FAILURE, 1424 "sysdb_attrs_primary_name_list failed [%d]: %s\n", (gdb) p *ldap_parentlist[0] $4 = { <struct sysdb_attrs> num = 8 { <struct ldb_message_element> flags = 0, name = 0x1182b20 "originalDN", num_values = 1 { <struct ldb_val> data = 0x1183370 "cn=group20,cn=groups,cn=accounts,dc=ipa,dc=test", length = 47 } } { <struct ldb_message_element> flags = 0, name = 0x116d0e0 "name", num_values = 1 { <struct ldb_val> data = 0x11808e0 "group20", length = 7 } } { <struct ldb_message_element> flags = 0, name = 0x115db10 "gidNumber", num_values = 1 { <struct ldb_val> data = 0x1183c20 "935600011", length = 9 } } { <struct ldb_message_element> flags = 0, name = 0x115dbc0 "member", num_values = 2 { <struct ldb_val> data = 0x1183e00 "cn=group10,cn=groups,cn=accounts,dc=ipa,dc=test", length = 47 } { <struct ldb_val> data = 0x1183ea0 "cn=group11,cn=groups,cn=accounts,dc=ipa,dc=test", length = 47 } } { <struct ldb_message_element> flags = 0, name = 0x1183d10 "uniqueID", num_values = 1 { <struct ldb_val> data = 0x11841c0 "1f9a98ba-5961-11e6-a51b-525400f71478", length = 36 } } { <struct ldb_message_element> flags = 0, name = 0x1184030 "objectSIDString", num_values = 1 { <struct ldb_val> data = 0x1184400 "S-1-5-21-925249755-300578800-2979754137-1011", length = 44 } } { <struct ldb_message_element> flags = 0, name = 0x11842d0 "originalModifyTimestamp", num_values = 1 { <struct ldb_val> data = 0x1175780 "20160803100057Z", length = 15 } } { <struct ldb_message_element> flags = 0, name = 0x1175880 "entryUSN", num_values = 1 { <struct ldb_val> data = 0x1183f40 "17299", length = 5 } } } (gdb)
name is unqualified and should be qualified.
ACK, but I won't push for now in case @lslebodn wants to run some tests before pushing.. """
See the full comment at https://github.com/SSSD/sssd/pull/7#issuecomment-243555414
sssd-devel@lists.fedorahosted.org