URL: https://github.com/SSSD/sssd/pull/5882 Author: thalman Title: #5882: CONFDB: check the return values Action: opened
PR body: """ Covscan pointed out that return value of chown and sete[ug]id is not checked in some cases. There is not much we can do in case of failure so only minor failure is logged.
Resolves: https://github.com/SSSD/sssd/issues/5876 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5882/head:pr5882 git checkout pr5882
URL: https://github.com/SSSD/sssd/pull/5882 Title: #5882: CONFDB: check the return values
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5882 Title: #5882: CONFDB: check the return values
thalman commented: """
In the commit message you mention fixing `setuid()` and `setegid()` but you are also fixing `chown()` in this PR.
Fixing chown return value is also claimed in the commit message
"""
See the full comment at https://github.com/SSSD/sssd/pull/5882#issuecomment-973860781
URL: https://github.com/SSSD/sssd/pull/5882 Author: thalman Title: #5882: CONFDB: check the return values Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5882/head:pr5882 git checkout pr5882
URL: https://github.com/SSSD/sssd/pull/5882 Title: #5882: CONFDB: check the return values
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5882 Title: #5882: CONFDB: check the return values
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5882 Title: #5882: CONFDB: check the return values
elkoniu commented: """ I run CI on my local machine and both: unit tests and integration tests looks to be green, ACK from me. """
See the full comment at https://github.com/SSSD/sssd/pull/5882#issuecomment-977823976
URL: https://github.com/SSSD/sssd/pull/5882 Title: #5882: CONFDB: check the return values
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5882 Title: #5882: CONFDB: check the return values
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5882 Title: #5882: CONFDB: check the return values
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5882 Title: #5882: CONFDB: check the return values
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5882
* `master` * 54dd529d2777edc625e25c5ebd259b396360337c - CONFDB: check the return values
"""
See the full comment at https://github.com/SSSD/sssd/pull/5882#issuecomment-979155449
URL: https://github.com/SSSD/sssd/pull/5882 Title: #5882: CONFDB: check the return values
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5882 Title: #5882: CONFDB: check the return values
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5882 Title: #5882: CONFDB: check the return values
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5882 Author: thalman Title: #5882: CONFDB: check the return values Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5882/head:pr5882 git checkout pr5882
sssd-devel@lists.fedorahosted.org