URL:
https://github.com/SSSD/sssd/pull/5360
Title: #5360: SDAP: set common options for sockets open by libldap
sumit-bose commented:
"""
> I was just thinking that in theory LDAP_OPT_NETWORK_TIMEOUT
might either completely 0 or at least tv->tv_sec is 0 while tv->tv_usec isn't.
The latter should currently not be possible since we and ldap.conf only sets the value to
full seconds. Nevertheless I wonder if the case should be somehow treated specially or
skipped?
I was thinking about this as well, but
[`set_fd_common_opts`](https://github.com/SSSD/sssd/blob/master/src/util/sss_sockets.c#L116)
has this check already.
Do you think it makes sense to check here additionally?
Hi,
I was thinking, since if I understand it correctly LDAP_OPT_NETWORK_TIMEOUT=0 means to
have the timeout as short as possible, that in this case calling
`set_fd_common_opts()`with a timeout of 1s which is the shortest the call cannot currently
handle, might be suitable. But I realized that this is not handled in the other code path
calling `set_fd_common_opts()` as well so we can move thinking about this to a new
ticket.
Given that I agree with your patch, I'll run some tests.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5360#issuecomment-707072532