On Tue, Feb 07, 2012 at 01:40:39PM +0100, Jan Zelený wrote:
With all these changes happening in last two weeks, the IPA hosts
code was
messy at best. This patch sorts out some of the mess. I already did some
testing: SELinux and HBAC seem to be working correctly. Honza, please take a
look and test this patch with your SSH-related code. That is the last code
that uses host fetching.
If this patch makes it to master, I plan to do some more cleanup in the HBAC
code which is closely related to the code this patch cleans.
Thanks
Jan
None of the new options is documented or has a configAPI entry. If
that's intentional to avoid breaking string freeze, then there should be a
ticket to track adding them.
...or...
I was actually thinking if we want to document the IPA attribute maps at
all. The options clutter the manual page and their value is
questionable. Would anyone oppose *removing* all the attribute maps from
the IPA manual page? Or at the very least moving them into some section
down at the bottom where noone would be confused by the options.
struct sdap_attr_map ipa_host_map[] = {
{ "ipa_host_object_class", "ipaHost", SYSDB_HOST_CLASS, NULL },
- { "ipa_host_fqdn", "fqdn", SYSDB_NAME, NULL },
- { "ipa_host_member_of", "memberOf", SYSDB_MEMBEROF, NULL },
- { "ipa_host_ssh_public_key", "ipaSshPubKey", SYSDB_SSH_PUBKEY,
NULL }
+ { "ipa_host_name", "cn", SYSDB_NAME, NULL },
+ { "ipa_host_fqdn", "fqdn", SYSDB_FQDN, NULL },
+ { "ipa_host_serverhostname", "serverHostname",
SYSDB_SERVERHOSTNAME, NULL },
+ { "ipa_host_member_of", "memberOf", SYSDB_ORIG_MEMBEROF, NULL
},
+ { "ipa_host_ssh_public_key", "ipaSshPubKey", SYSDB_SSH_PUBKEY,
NULL },
+ { "ipa_hostgroup_uuid", "ipaUniqueID", SYSDB_UUID, NULL}
You probably meant to use ipa_host_uuid here.
+};
+
The host_map and hostgroup_map seem to be IPA specific, is it possible
to move them to "struct ipa_options" ?