This will make confdb coherent with changes made in sysdb. Not using context hierarchy will help detecting memory leaks if there are some.
Jan
On Fri, Feb 10, 2012 at 02:21:01PM +0100, Jan Zelený wrote:
This will make confdb coherent with changes made in sysdb. Not using context hierarchy will help detecting memory leaks if there are some.
Self nack on the first version, I skipped one call of confdb_get_int() in ssh module. New patch attached.
Jan
nack, you still need to free tmp_ctx even if you free its contents.
On Fri, Feb 10, 2012 at 02:21:01PM +0100, Jan Zelený wrote:
This will make confdb coherent with changes made in sysdb. Not using context hierarchy will help detecting memory leaks if there are some.
Self nack on the first version, I skipped one call of confdb_get_int() in ssh module. New patch attached.
Jan
nack, you still need to free tmp_ctx even if you free its contents.
Thanks, Fixed patch in attachment.
Jan
On Mon, Feb 20, 2012 at 05:25:06PM +0100, Jan Zelený wrote:
On Fri, Feb 10, 2012 at 02:21:01PM +0100, Jan Zelený wrote:
This will make confdb coherent with changes made in sysdb. Not using context hierarchy will help detecting memory leaks if there are some.
Self nack on the first version, I skipped one call of confdb_get_int() in ssh module. New patch attached.
Jan
nack, you still need to free tmp_ctx even if you free its contents.
Thanks, Fixed patch in attachment.
Jan
Sorry, but still a nack. You're only freeing tmp_ctx in the failed: label, you need to free it in both success and failure cases.
On Mon, Feb 20, 2012 at 05:25:06PM +0100, Jan Zelený wrote:
On Fri, Feb 10, 2012 at 02:21:01PM +0100, Jan Zelený wrote:
This will make confdb coherent with changes made in sysdb. Not using context hierarchy will help detecting memory leaks if there are some.
Self nack on the first version, I skipped one call of confdb_get_int() in ssh module. New patch attached.
Jan
nack, you still need to free tmp_ctx even if you free its contents.
Thanks, Fixed patch in attachment.
Jan
Sorry, but still a nack. You're only freeing tmp_ctx in the failed: label, you need to free it in both success and failure cases.
This is what I get when I send patches in haste, sorry for the inconvenience. Hopefully this will be the last patch in the row :)
Jan
On Tue, Feb 21, 2012 at 09:38:28AM +0100, Jan Zelený wrote:
On Mon, Feb 20, 2012 at 05:25:06PM +0100, Jan Zelený wrote:
On Fri, Feb 10, 2012 at 02:21:01PM +0100, Jan Zelený wrote:
This will make confdb coherent with changes made in sysdb. Not using context hierarchy will help detecting memory leaks if there are some.
Self nack on the first version, I skipped one call of confdb_get_int() in ssh module. New patch attached.
Jan
nack, you still need to free tmp_ctx even if you free its contents.
Thanks, Fixed patch in attachment.
Jan
Sorry, but still a nack. You're only freeing tmp_ctx in the failed: label, you need to free it in both success and failure cases.
This is what I get when I send patches in haste, sorry for the inconvenience. Hopefully this will be the last patch in the row :)
Jan
It seems that not all the calls were converted: CC src/responder/nss/nsssrv_netgroup.o src/responder/nss/nsssrv.c: In function ‘nss_process_init’: src/responder/nss/nsssrv.c:317:26: warning: passing argument 2 of ‘confdb_get_int’ from incompatible pointer type [enabled by default] ./src/confdb/confdb.h:346:5: note: expected ‘const char *’ but argument is of type ‘struct resp_ctx *’ src/responder/nss/nsssrv.c:317:26: warning: passing argument 4 of ‘confdb_get_int’ makes integer from pointer without a cast [enabled by default] ./src/confdb/confdb.h:346:5: note: expected ‘int’ but argument is of type ‘const char *’ src/responder/nss/nsssrv.c:317:26: warning: passing argument 5 of ‘confdb_get_int’ makes pointer from integer without a cast [enabled by default] ./src/confdb/confdb.h:346:5: note: expected ‘int *’ but argument is of type ‘int’ src/responder/nss/nsssrv.c:317:26: error: too many arguments to function ‘confdb_get_int’ ./src/confdb/confdb.h:346:5: note: declared here
This is probably a rebase on top of the recent fd limit patches.
On Tue, Feb 21, 2012 at 09:38:28AM +0100, Jan Zelený wrote:
On Mon, Feb 20, 2012 at 05:25:06PM +0100, Jan Zelený wrote:
On Fri, Feb 10, 2012 at 02:21:01PM +0100, Jan Zelený wrote:
> This will make confdb coherent with changes made in sysdb. Not > using context hierarchy will help detecting memory leaks if > there are some.
Self nack on the first version, I skipped one call of confdb_get_int() in ssh module. New patch attached.
Jan
nack, you still need to free tmp_ctx even if you free its contents.
Thanks, Fixed patch in attachment.
Jan
Sorry, but still a nack. You're only freeing tmp_ctx in the failed: label, you need to free it in both success and failure cases.
This is what I get when I send patches in haste, sorry for the inconvenience. Hopefully this will be the last patch in the row :)
Jan
It seems that not all the calls were converted: CC src/responder/nss/nsssrv_netgroup.o src/responder/nss/nsssrv.c: In function ‘nss_process_init’: src/responder/nss/nsssrv.c:317:26: warning: passing argument 2 of ‘confdb_get_int’ from incompatible pointer type [enabled by default] ./src/confdb/confdb.h:346:5: note: expected ‘const char *’ but argument is of type ‘struct resp_ctx *’ src/responder/nss/nsssrv.c:317:26: warning: passing argument 4 of ‘confdb_get_int’ makes integer from pointer without a cast [enabled by default] ./src/confdb/confdb.h:346:5: note: expected ‘int’ but argument is of type ‘const char *’ src/responder/nss/nsssrv.c:317:26: warning: passing argument 5 of ‘confdb_get_int’ makes pointer from integer without a cast [enabled by default] ./src/confdb/confdb.h:346:5: note: expected ‘int *’ but argument is of type ‘int’ src/responder/nss/nsssrv.c:317:26: error: too many arguments to function ‘confdb_get_int’ ./src/confdb/confdb.h:346:5: note: declared here
This is probably a rebase on top of the recent fd limit patches.
This is just embarrassing. I could have sworn I tried to rebuild SSSD ... apparently not. Thanks for catching this rebase issue. Patch attached.
Jan
On Tue, Feb 21, 2012 at 04:07:16PM +0100, Jan Zelený wrote:
On Tue, Feb 21, 2012 at 09:38:28AM +0100, Jan Zelený wrote:
On Mon, Feb 20, 2012 at 05:25:06PM +0100, Jan Zelený wrote:
On Fri, Feb 10, 2012 at 02:21:01PM +0100, Jan Zelený wrote: > > This will make confdb coherent with changes made in sysdb. Not > > using context hierarchy will help detecting memory leaks if > > there are some. > > Self nack on the first version, I skipped one call of > confdb_get_int() in ssh module. New patch attached. > > Jan
nack, you still need to free tmp_ctx even if you free its contents.
Thanks, Fixed patch in attachment.
Jan
Sorry, but still a nack. You're only freeing tmp_ctx in the failed: label, you need to free it in both success and failure cases.
This is what I get when I send patches in haste, sorry for the inconvenience. Hopefully this will be the last patch in the row :)
Jan
It seems that not all the calls were converted: CC src/responder/nss/nsssrv_netgroup.o src/responder/nss/nsssrv.c: In function ‘nss_process_init’: src/responder/nss/nsssrv.c:317:26: warning: passing argument 2 of ‘confdb_get_int’ from incompatible pointer type [enabled by default] ./src/confdb/confdb.h:346:5: note: expected ‘const char *’ but argument is of type ‘struct resp_ctx *’ src/responder/nss/nsssrv.c:317:26: warning: passing argument 4 of ‘confdb_get_int’ makes integer from pointer without a cast [enabled by default] ./src/confdb/confdb.h:346:5: note: expected ‘int’ but argument is of type ‘const char *’ src/responder/nss/nsssrv.c:317:26: warning: passing argument 5 of ‘confdb_get_int’ makes pointer from integer without a cast [enabled by default] ./src/confdb/confdb.h:346:5: note: expected ‘int *’ but argument is of type ‘int’ src/responder/nss/nsssrv.c:317:26: error: too many arguments to function ‘confdb_get_int’ ./src/confdb/confdb.h:346:5: note: declared here
This is probably a rebase on top of the recent fd limit patches.
This is just embarrassing. I could have sworn I tried to rebuild SSSD ... apparently not. Thanks for catching this rebase issue. Patch attached.
Jan
Ack
On Tue, 2012-02-21 at 16:47 +0100, Jakub Hrozek wrote:
On Tue, Feb 21, 2012 at 04:07:16PM +0100, Jan Zelený wrote:
On Tue, Feb 21, 2012 at 09:38:28AM +0100, Jan Zelený wrote:
On Mon, Feb 20, 2012 at 05:25:06PM +0100, Jan Zelený wrote:
> On Fri, Feb 10, 2012 at 02:21:01PM +0100, Jan Zelený wrote: > > > This will make confdb coherent with changes made in sysdb. Not > > > using context hierarchy will help detecting memory leaks if > > > there are some. > > > > Self nack on the first version, I skipped one call of > > confdb_get_int() in ssh module. New patch attached. > > > > Jan > > nack, you still need to free tmp_ctx even if you free its contents.
Thanks, Fixed patch in attachment.
Jan
Sorry, but still a nack. You're only freeing tmp_ctx in the failed: label, you need to free it in both success and failure cases.
This is what I get when I send patches in haste, sorry for the inconvenience. Hopefully this will be the last patch in the row :)
Jan
It seems that not all the calls were converted: CC src/responder/nss/nsssrv_netgroup.o src/responder/nss/nsssrv.c: In function ‘nss_process_init’: src/responder/nss/nsssrv.c:317:26: warning: passing argument 2 of ‘confdb_get_int’ from incompatible pointer type [enabled by default] ./src/confdb/confdb.h:346:5: note: expected ‘const char *’ but argument is of type ‘struct resp_ctx *’ src/responder/nss/nsssrv.c:317:26: warning: passing argument 4 of ‘confdb_get_int’ makes integer from pointer without a cast [enabled by default] ./src/confdb/confdb.h:346:5: note: expected ‘int’ but argument is of type ‘const char *’ src/responder/nss/nsssrv.c:317:26: warning: passing argument 5 of ‘confdb_get_int’ makes pointer from integer without a cast [enabled by default] ./src/confdb/confdb.h:346:5: note: expected ‘int *’ but argument is of type ‘int’ src/responder/nss/nsssrv.c:317:26: error: too many arguments to function ‘confdb_get_int’ ./src/confdb/confdb.h:346:5: note: declared here
This is probably a rebase on top of the recent fd limit patches.
This is just embarrassing. I could have sworn I tried to rebuild SSSD ... apparently not. Thanks for catching this rebase issue. Patch attached.
Jan
Ack
Pushed to master.
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Jan Zelený -
Stephen Gallagher