URL: https://github.com/SSSD/sssd/pull/1011 Author: pbrezina Title: #1011: sysdb: check if the id override belongs to requested domain Action: opened
PR body: """ Steps to reproduce: 1. Setup an id override (administrator@ad.vm: uid -> 10001) 2. Request user by name to fill cache ``` $ id Administrator@ad.vm uid=10001(administrator@ad.vm) ... ``` 3. Request user by id and see that domain part is missing ``` $ id 10001 uid=10001(administrator) ... ```
First, the uid is looked up in IPA domain and the override object is found when we hit `sysdb_search_override_by_id` because id values are not qualified. Therefore the origin object (administrator@ad.vm) is returned as part of IPA domain.
We need to check if the original object belongs to the requested domain.
Resolves: https://pagure.io/SSSD/sssd/issue/4173 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1011/head:pr1011 git checkout pr1011
URL: https://github.com/SSSD/sssd/pull/1011 Title: #1011: sysdb: check if the id override belongs to requested domain
Label: +branch: sssd-1-16
URL: https://github.com/SSSD/sssd/pull/1011 Title: #1011: sysdb: check if the id override belongs to requested domain
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/1011 Title: #1011: sysdb: check if the id override belongs to requested domain
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/1011 Title: #1011: sysdb: check if the id override belongs to requested domain
alexey-tikhonov commented: """ Covscan is clear.
ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/1011#issuecomment-617278626
URL: https://github.com/SSSD/sssd/pull/1011 Title: #1011: sysdb: check if the id override belongs to requested domain
Label: +Ready to push
sssd-devel@lists.fedorahosted.org