On Thu, May 02, 2013 at 04:46:32PM +0200, Jakub Hrozek wrote:

Hi,

Timo Aaltonen discovered that one of our fail over unit tests require the "localhost" host name to be resolvable, while there is no guarantee that a buildsystem that runs the build can resolve "localhost".

Attached are three very small patches:

[PATCH 1/3] tests: Do not attempt to resolve localhost unless -n is selected This patch disables the test that was relying on "localhost".

[PATCH 2/3] tests: enable network tests based on environment variable Currently the tests that require a network connection can be enabled by selecting the -n command line parameter for the test. But in some cases, like the buildsystems, it might be better to actually enable network tests globally for all tests.

I no longer think there is much value in these two patches. It turned out that Timo's build environment was just misconfigured. At present, all build systems we know about are able to resolve localhost, so I'd prefer to keep the test enabled now. We can always resume the patches when/if this issue resurfaces.

[PATCH 3/3] RPM: run network tests by default Enables the unit tests that require a network connectin before calling "make check". I tried building a SRPM with these changes in Koji and the build succeeded: http://koji.fedoraproject.org/koji/taskinfo?taskID=5325056

This patch is wrong, Koji prevents network connections.