On 05/13/2011 12:16 AM, Simo Sorce wrote:
On Thu, 2011-05-12 at 13:24 -0400, Stephen Gallagher wrote:
> On Mon, 2011-05-09 at 13:49 -0400, Stephen Gallagher wrote:
>> On Mon, 2011-05-09 at 10:45 +0200, Jakub Hrozek wrote:
>>> We were leaking "dummy" and "copy" in
expand_ccname_template. The
>>> attached patch switches to using a temporary memory context and only
>>> talloc_move the result on success.
>>
>> Ack.
>
> Pushed to master.
Too late, but using the label "done" would have better reflected reality
given that code is used both in failure and in success cases.
Simo.
Code hygiene is important. As I consider this a "trivial" change in Trac
terminology, I'll squash it in another patch.