URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: opened
PR body: """ This is a set of patches intended to enable higher log level by default.
Currently I target SSSDBG_OP_FAILURE (level 2) as a default (It seems SSSDBG_MINOR_FAILURE level contains legitimate messages that admin can deliberately ignore, and those messages can get quite spammy)
Perhaps several patches are yet missing (I'm awaiting @sumit-bose response) but those already published are ready for review. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
alexey-tikhonov commented: """ @sgoveas , could you please take a look at the test `TestSanityKCM.test_kcm_debug_level_set`? This test is broken by this PR. Do I understand correctly it relies on the default debug_level=0? This PR changes this... """
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-736840824
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
sgoveas commented: """
@sgoveas , could you please take a look at the test `TestSanityKCM.test_kcm_debug_level_set`? This test is broken by this PR. Do I understand correctly it relies on the default debug_level=0? This PR changes this...
yes it checks there are no logs generated in sssd_kcm.log with debug_level=0
"""
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-737183667
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
sgoveas commented: """
@sgoveas , could you please take a look at the test `TestSanityKCM.test_kcm_debug_level_set`? This test is broken by this PR. Do I understand correctly it relies on the default debug_level=0? This PR changes this...
yes it checks there are no logs generated in sssd_kcm.log with debug_level=0
"""
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-737183667
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
alexey-tikhonov commented: """
I know that main idea behind this PR is to change default log level and not mess with the log message. Still, maybe this is good moment to unify some common values representation like strings and numbers. Also we could change logs printing function names to say something more meaningful for the user. At the end advanced user will end up reading the code and common user will not care if talloc_*_() function failed etc.
Yes, this makes sense. But not within this PR. It is huge already and topics are different indeed. """
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-737233628
URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
alexey-tikhonov commented: """
@sgoveas , could you please take a look at the test `TestSanityKCM.test_kcm_debug_level_set`? This test is broken by this PR. Do I understand correctly it relies on the default debug_level=0? This PR changes this...
yes it checks there are no logs generated in sssd_kcm.log with debug_level=0
@sgoveas , with debug patch the following is seen in the output: ``` /var/log/sssd/sssd_kcm.log (2020-12-02 18:17:50): [kcm] [server_setup] (0x0040): Starting with debug level = 0x0070 -----x----x----x----x-----x----x---- ``` So seems test uses default log level, not debug_level=0? """
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-737458244
URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
alexey-tikhonov commented: """ There was an old bug that prevented setting debug_level = 0 in sssd.conf explicitly. Pushed additional patch to fix it. """
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-738306459
URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
alexey-tikhonov commented: """ It's preferably to include fix for #5425 in this PR. """
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-740060424
URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
alexey-tikhonov commented: """ Again, "those already published are ready for review" """
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-744080483
URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
alexey-tikhonov commented: """ Hi @sumit-bose ,
thanks for your responses. I think I addressed most of them.
Could you please take a look at a result? """
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-745457879
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
sumit-bose commented: """ Hi,
thanks for the thorough examination. I added a few minor comments in-line.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-748941810
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
alexey-tikhonov commented: """
Hi,
thanks for the thorough examination. I added a few minor comments in-line.
Hi,
thank you for the review. I addressed your comments, please take a look at a new version. """
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-749591139
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
sumit-bose commented: """ Hi,
thanks for the fixes, ACK.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-749621848
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
sumit-bose commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5422
* `master` * bd2f38abe95645b9b16b12d12dac6008b0d2a03b - UTIL: find_domain_by_object_name_ex() changed log level * 0db68a1f95612fcbad18ca8107a4b170f446dd59 - LDAP: sdap_save_grpmem(): log level changed * 00e3ac4a4f9b6c8da27daa3ed8c18664c99256bb - LDAP: reduce log level in case of fail to store members of missing group (it might be built-in skipped intentionally) * dba7de0db3cbaee43ef06a1b7c847fbcf48f3708 - SYSDB: changed logging in sysdb_get_real_name() * e86599ba079611ed324ff1493a7173d11c1a7961 - IPA: changed logging in ipa_get_subdom_acct_send() * bf873598a9d4ac8256b20859c0d92fb509861b6b - IPA: ignore failed group search in certain cases * 60b17be9e4f4865fe1774076808a6c783a7ec906 - SYSDB: changed log level in sysdb_update_members_ex() * 9390af3c2d1b33e2b5ded0ea0c6c436b9776cedc - IPA: reduce log level in apply_subdomain_homedir() * 9215cf4e2519d5f085bf97f26a74d499090e46e1 - CERTMAP: removed stray debug message * 0986cf6ced8c4e09b8031d19eddffca679aca30c - UTIL: fixed bug in server_setup() that prevented setting debug level to 0 explicitly * 644453f8d93540a91236683015f3418d29c6d95a - LOGS: default log level changed to <= SSSDBG_OP_FAILURE * 4fe060abbe958c2f9b5aa44e489620063029aa0b - FILES: reduced debug level in refresh_override_attrs() if case "No overrides, nothing to do" * 29f243fd5b256efe3c7f4e4f0940c7d0ae6b4fa1 - AD: reduced log level in case check_if_pac_is_available() can't find user entry. This is typical situation when, for example, INITGROUPS lookup is executed for uncached user. * ed6ec569780ad8203c4990faed5a9f0dc27dd12b - SDAP: reduced log level in case group without members * 26fdc3c8f0ae6493442ea291d9bf36ba148ef209 - CACHE_REQ: reduced log level in cache_req_object_by_name_well_known() Non fqdn input isn't necessarily an error here. * a7b145b99b9f71ad3d02251fff5b587041c9f1ab - LDAP: reduced log level in hosts_get_done() * 6e3b4d745fc8d2de14d69aa30bc21aa549a435f8 - SBUS: reduced log level in case of unexpected signal * 90dae38d7442757b8a51f91a6ba3fb83f99320a1 - RESPONDER: reduce log level in sss_parse_inp_done() in case of "Unknown domain" since this might be search by UPN * 69aa3e8c4b82a06e45ba59eb1c17af252aa971ce - DP: do not log failure in case provider doesn't support check_online method * 1af89925e62cccacb2957f55b16988a5e71fe5e1 - IPA: corrected confusing message * a419b7e673d2de571d873b79be31b1ae2fa89832 - SSS_IFACE: corrected misleading return code * 99e44d9db41f5bb56281ed65d815c32139195931 - LDAP: added missed \n in log message * 52dc85540e621b00f358fea94e2e390d580948d8 - SYSDB: reduce log level in sysdb_update_members_ex() in case failed attempt to DEL unexisting attribute * a7b6413d9fb870f51f09955bdceee01952442c63 - UTIL: sss_ldb_error_to_errno() improved * ac22859006b5658017b2720ca3e02d34c5beecdd - PAM: reduce log level in may_do_cert_auth() * 5068655a67f88cb1730f28689c5effee264321ad - UTIL: few debug message corrections * 3cbd0465b52f9bbb7e20b0b12e154f51bab0866e - PAM: few debug message corrections * f028253ff87bf11ed034ad5acf1f67e8863bed60 - NSS: few debug message corrections * f457a1a69240381ad7637a09dc66c1aeb78e1d18 - IFP: few debug message corrections * 058644f2ef6d1958db657d371158d2df7798dd49 - RESPONDER: few debug message corrections * 01ba32f250a0e51771471c52440c11f6f05f2a48 - CACHE_REQ: debug message correction * 018c08acbb3bbb836c9acefaf5c384eb9231a60a - AUTOFS: few debug message corrections * fb052a4c9843ce518a7202d842c43631f8bbfd2d - RESOLV: debug message correction * d91409df456f9ad7aad39d0cad0ed053cf1f3653 - PROXY: few debug message corrections * ff8f44ce2d2eedb098d980793a949f7f7e55576a - LDAP: few debug message corrections * 9244820af59ba6b947cf9aa1269d03bb6f2e4f38 - KRB5: few debug message corrections * 667b983aaee380c50d50ef07542b004e60041581 - IPA: few debug message corrections * 2f70695a874dcb84d4b86773138a5a6b6259958f - DP: few debug message corrections * d6f6f053d7a97a220b52ce92fd653eef8cec5a74 - AD: few debug message corrections * 85d8adc4d24f09e47f2a9c0fa595d90c61036b18 - P11_CHILD: severity level of few debug messages adjusted * fe0530ef96baa8fd39ce6b87c0c760e17c5eb6f8 - MONITOR: severity level of few debug messages adjusted * daa5454f870a5436a554091a1333cc8be0cbc566 - SYSDB:views: few debug message corrections * 82dc14b027f9115cabafce71d2b385d5c7d1dd4f - SYSDB:upgrade: debug message corrected * e731368ed9cea9b35d0ae654e1534084c6ef4642 - SYSDB:service: severity level of few debug messages adjusted * f55c9599068c43037a8b666af92ba9b8a044f735 - SYSDB:selinux: debug message severity level was adjusted * 744582419abfd6e5665315748d44e732f1d56f13 - SYSDB:search: few debug messages were corrected * 033c31a2a4994367edea1ded8303a0d2dbc59b1c - SYSDB:ops: few debug messages were corrected * a73df70ee0bcc8f1b80a2e20132592724bd5f675 - SYSDB:ipnetworks: severity level of few debug messages adjusted * b4acf71d0a81aeeb2754645d2798ce1e927121f3 - SYSDB:iphosts: severity level of few debug messages adjusted * d8af1db84b48193a546bbeec84a7dd7e2b132244 - SYSDB:sudo: changed debug message to be consistent * df723cb98b406b0262f04d0e43e8e5bf0030074f - SYSDB: wrong debug message corrected * e350d917e6d48c1d13502ab2849d3e2a0815215e - SYSDB:autofs: cosmetic updates
"""
See the full comment at https://github.com/SSSD/sssd/pull/5422#issuecomment-749709695
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5422 Author: alexey-tikhonov Title: #5422: Logs review Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5422/head:pr5422 git checkout pr5422
URL: https://github.com/SSSD/sssd/pull/5422 Title: #5422: Logs review
Label: +Pushed
sssd-devel@lists.fedorahosted.org