On Fri, Feb 27, 2015 at 05:21:29PM +0100, Pavel Březina wrote:
On 02/25/2015 08:22 PM, Jakub Hrozek wrote:
>On Wed, Feb 25, 2015 at 04:15:07PM +0100, Pavel Březina wrote:
>>On 02/17/2015 08:59 PM, Jakub Hrozek wrote:
>>>Hi,
>>>
>>>the attached patch implements using TTLs in our failover code instead of
>>>hardcoded refresh value and includes a unit test.
>>
>>Hi,
>>the patch looks good in general. but you are missing assignment to _ttl in
>>fo_discover_servers_recv.
>
>What a silly oversight, thanks for catching that.
Hi,
I have one question: it seems that you have changed default ttl to its half,
from 14400 to 7200. Why is that?
Because I didn't realize the default TTL in the resolver is different,
thanks for catching that.
I also noticed that there is no debug message... it may be useful to print
acquired ttl.
Done, in the same patch as fixup of the default TTL.
Thanks for the careful review.