On Tue, Oct 20, 2009 at 08:48:19PM -0400, Simo Sorce wrote:
On Wed, 2009-10-21 at 17:15 +0200, Sumit Bose wrote:
> On Tue, Oct 20, 2009 at 07:46:02PM -0400, Simo Sorce wrote:
> > On Mon, 2009-10-19 at 16:42 +0200, Sumit Bose wrote:
> > > Hi,
> > >
> > > this patch adds a store/search/delete sysdb API for data not related
> > > to
> > > users of groups. The data is stored in cn=custom,cn=domain,cn=sysdb.
> > > The
> > > client must specify a subtree_name and an object_name to save the data
> > > in cn=object_name,cn=subtree_name,cn=custom,cn=domain,cn=sysdb.
> > >
> > > Please have a look at the sysdb_check_handle_* request, too. I think
> > > it
> > > makes the code more readable and helps to reduce code duplications.
> > Why are you deleting and re-adding the entry in custom store ?
> > Why not just replace the attributes you want to set ?
ok, the attached version adds new objects or replaces existing and adds
new attributes to existing objects.
> > Simo.
> I think it is a typical use case that you want to store a copy of some
> LDAP search result and replacing all exiting data. Maybe a update call
> can be integrated when needed.
Then the name seem misleading, you should s/store/replace/ ?
Or maybe have an option like bool replace true/false ?