On Tue, Aug 2, 2016 at 2:16 PM, Thorsten Scherf tscherf@redhat.com wrote:
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
Acked-by: Fabiano Fidêncio fidencio@redhat.com
A simple patch like this one doesn't require CI tests, right? I have no rights to push the patch, so, if someone else can do would be super!
Best Regards,
On Wed, Aug 03, 2016 at 09:46:46AM +0200, Fabiano Fidêncio wrote:
On Tue, Aug 2, 2016 at 2:16 PM, Thorsten Scherf tscherf@redhat.com wrote:
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
Acked-by: Fabiano Fidêncio fidencio@redhat.com
A simple patch like this one doesn't require CI tests, right? I have no rights to push the patch, so, if someone else can do would be super!
For manpage patches, we normally don't require a CI run (unless the manpage contains conditionals evaluated differently on different platforms..), just make sure the manpage builds.
For man page patches, we also usually require that a native speaker acks the patch to make sure it's written in proper English, but since this patch only fixes a typo, I don't think it's required either.
* master: 2a03170b6990c37ac2f7376ea740613c47ef2573
Just looked at this now, didnt realize it was just two lines, changes look good. ;)
On Thu, Aug 4, 2016 at 5:25 AM, Jakub Hrozek jhrozek@redhat.com wrote:
On Wed, Aug 03, 2016 at 09:46:46AM +0200, Fabiano Fidêncio wrote:
On Tue, Aug 2, 2016 at 2:16 PM, Thorsten Scherf tscherf@redhat.com
wrote:
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@
lists.fedorahosted.org
Acked-by: Fabiano Fidêncio fidencio@redhat.com
A simple patch like this one doesn't require CI tests, right? I have no rights to push the patch, so, if someone else can do would be
super!
For manpage patches, we normally don't require a CI run (unless the manpage contains conditionals evaluated differently on different platforms..), just make sure the manpage builds.
For man page patches, we also usually require that a native speaker acks the patch to make sure it's written in proper English, but since this patch only fixes a typo, I don't think it's required either.
- master: 2a03170b6990c37ac2f7376ea740613c47ef2573
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@ lists.fedorahosted.org
sssd-devel@lists.fedorahosted.org