Thanks for review, Stephen.
Here's the fixed version of the patchset.
On 02/06/2014 03:16 PM, Stephen Gallagher wrote:
Minor nitpick: some lines are now longer than 79 characters.
Thanks, fixed.
Could you correct the comment on warn() to read that it builds with
default optimization? Since we are actually setting CFLAGS+= here, it
really isn't using the defaults.
Done in an additional patch.
You didn't add "$@" to the sssinstall() function, but I
doubt that
matters (since I doubt anyone is passing extra arguments to restorecon...)
Yes, this was intentional.
General statement: if we're moving these to functions, it would
be
nice to have real exit codes for them, rather than using && all over
the place. Checking the output of each phase and printing an error if
it fails would be useful. This is not a blocker to these patches, but
nice to think about.
I'm not sure this is necessary, but I'll think about it.
Sincerely,
Nick