On 04/28/2014 09:38 PM, Jakub Hrozek wrote:

On Fri, Apr 11, 2014 at 04:52:27PM +0200, Michal Židek wrote:

...

Resolves:

https://fedorahosted.org/sssd/ticket/2304

I also renamed the create_order_array() function into init_map_order_ctx. It seems to be more appropriate name now.

Patch is attached.

Thanks, Michal

Hi,

the patch looks good to me, but I couldn't test it because it no longer applies on master, can you rebase? Sorry for the delay in reviewing.

Sorry for delayed answer. The rebased patch is attached.

Michal

On Mon, May 12, 2014 at 01:08:38PM +0200, Jakub Hrozek wrote:

On Wed, May 07, 2014 at 04:51:37PM +0200, Michal Židek wrote:

...

On 04/28/2014 09:38 PM, Jakub Hrozek wrote:

...

On Fri, Apr 11, 2014 at 04:52:27PM +0200, Michal Židek wrote:

...

Resolves:

https://fedorahosted.org/sssd/ticket/2304

I also renamed the create_order_array() function into init_map_order_ctx. It seems to be more appropriate name now.

Patch is attached.

Thanks, Michal

Hi,

the patch looks good to me, but I couldn't test it because it no longer applies on master, can you rebase? Sorry for the delay in reviewing.

Sorry for delayed answer. The rebased patch is attached.

Michal

Still looks good and passed my tests.

ACK

Pushed to master: 785cfb3dfdd8f38426e71e6161581e85f4f8f941