On 05/05/2010 05:10 PM, Petter Reinholdtsen wrote:
Hi. You get this email as one of the sssd developers. I failed to
find any information in the tarball about where to email patches, so I
ended up sending it to your individual email addresses.
Ah, you're right. We really should add a pointer to our devel list
(sssd-devel(a)lists.fedorahosted.org) and our wiki
(
https://fedorahosted.org/sssd)
I'm currently looking into building a Debian package, and based on the
Ubuntu patches I see the need to pass --install-layout=deb to the
setup.py script. The attached patch make it possible to do so without
having to patch the source. Please include it in a future version of
sssd.
I assume you will leave the DISTSETUPOPTS variable empty in your
version, but included its content in my patch to show what it would be
set to in a Debian build. It is only needed for the install run of
setup.py.
Happy hacking,
Looking at the patch, I think it needs a little bit of rework. We don't
want to default to passing DISTSETUPOPTS = --install-layout=deb as it is
currently written.
Please take a look at sssd-1.1.1/src/external/platform.m4
You can add a Debian target there, and then have the Makefile.am set
DISTSETUPOPTS only when 'if HAVE_DEB' is true. I'm not familiar enough
with Debian to write these tests myself.
Please feel free to subscribe to the sssd-devel list at
https://fedorahosted.org/mailman/listinfo/sssd-devel for submitting
newer patches. I'm forwarding the current version there for posterity.
Thank you for your contributions!
--
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/