URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: opened
PR body: """ Since CONFDB_DOMAIN_LEGACY_PASS is legacy parameter that is rooted in pre-1.0 SSSD. We should just nuke it as we remove other legacy code.
Resolves: https://pagure.io/SSSD/sssd/issue/3530 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/397#issuecomment-333793488
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/397#issuecomment-333793489
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
amitkumar50 commented: """ Would be sending commit to remove 'domain->legacy_passwords' and related code. """
See the full comment at https://github.com/SSSD/sssd/pull/397#issuecomment-333793716
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
lslebodn commented: """ On (03/10/17 02:49), AmitKumar wrote:
Would be sending commit to remove 'domain->legacy_passwords' and related code.
I would prefer to remove it on all places in simple patch. (especially from sssd.config schema(s))
``` src/confdb/confdb.c: ret = get_entry_as_bool(res->msgs[0], &domain->legacy_passwords, src/confdb/confdb.h:#define CONFDB_DOMAIN_LEGACY_PASS "store_legacy_passwords" src/confdb/confdb.h: bool legacy_passwords; src/config/SSSDConfig/__init__.py.in: 'store_legacy_passwords' : _('Store password hashes'), src/config/SSSDConfig/sssd_upgrade_config.py: 'store_legacy_passwords' : 'store-legacy-passwords', src/config/SSSDConfigTest.py: 'store_legacy_passwords', src/config/SSSDConfigTest.py: 'store_legacy_passwords', src/config/cfg_rules.ini:option = store_legacy_passwords src/config/etc/sssd.api.conf:store_legacy_passwords = bool, None, false src/db/sysdb_ops.c: if (pwd && (domain->legacy_passwords || !*pwd)) { ```
"""
See the full comment at https://github.com/SSSD/sssd/pull/397#issuecomment-333797543
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
Label: +postponed until sssd 2.0
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
amitkumar50 commented: """ @fidencio Done Changes. """
See the full comment at https://github.com/SSSD/sssd/pull/397#issuecomment-410974638
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
fidencio commented: """ CI: http://vm-031.$%7Babc%7D/logs/job/91/73/summary.html """
See the full comment at https://github.com/SSSD/sssd/pull/397#issuecomment-411022210
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
jhrozek commented: """ * master: 1adf2f982c28096ca03b9910a412a8a63559ec10 """
See the full comment at https://github.com/SSSD/sssd/pull/397#issuecomment-412550531
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
amitkumar50 -
centos-ci
-
fidencio
-
jhrozek
-
lslebodn