Hi,
I'm still working on the SELinux provider unit tests, but mocking the interfaces it uses turned out to be more work than I anticipated, so I'm sending the patch without a test for now and will send the test asynchronously.
On 03/03/2015 11:32 AM, Jakub Hrozek wrote:
Hi,
I'm still working on the SELinux provider unit tests, but mocking the interfaces it uses turned out to be more work than I anticipated, so I'm sending the patch without a test for now and will send the test asynchronously.
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
LGTM, ci passed:
http://sssd-ci.duckdns.org/logs/job/8/58/summary.html
ACK
On 03/03/2015 11:32 AM, Jakub Hrozek wrote:
Hi,
I'm still working on the SELinux provider unit tests, but mocking the interfaces it uses turned out to be more work than I anticipated, so I'm sending the patch without a test for now and will send the test asynchronously.
Patch works for me.
Link to CI: http://sssd-ci.duckdns.org/logs/job/8/68/summary.html
ACK.
Michal
On Tue, Mar 03, 2015 at 10:46:29PM +0100, Michal Židek wrote:
On 03/03/2015 11:32 AM, Jakub Hrozek wrote:
Hi,
I'm still working on the SELinux provider unit tests, but mocking the interfaces it uses turned out to be more work than I anticipated, so I'm sending the patch without a test for now and will send the test asynchronously.
Patch works for me.
Link to CI: http://sssd-ci.duckdns.org/logs/job/8/68/summary.html
ACK.
Michal
Thank you both for the review.
* master: 01f78f755fde63997ccfded71fb8395569b11430 * sssd-1-12: 90efb3c2a48146d7b6cc81fe8422e9024144402a
sssd-devel@lists.fedorahosted.org