On Mon, 2013-08-26 at 22:10 +0200, Jakub Hrozek wrote:
> On Mon, Aug 26, 2013 at 05:24:42PM +0200, Sumit Bose wrote:
> > On Mon, Aug 26, 2013 at 05:12:25PM +0200, Jakub Hrozek wrote:
> > > An engineer from the BaseOS QE team found out that the SSSD does not
> > > work at all on big endian architectures..
> >
> > > From d65c01d15839cf06928ef3fa080832e0b669849c Mon Sep 17 00:00:00 2001
> > > From: Jakub Hrozek <jhrozek(a)redhat.com>
> > > Date: Mon, 26 Aug 2013 10:47:58 -0400
> > > Subject: [PATCH] DP: Use the correct type for DBus boolean
> > >
> > >
https://fedorahosted.org/sssd/ticket/2057
> > > ---
> > > src/responder/common/responder_get_domains.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/src/responder/common/responder_get_domains.c
b/src/responder/common/responder_get_domains.c
> > > index
592cd8dcd9e24d56617f85763504b1107e0dfcad..c7f4c36ba2c6c1779ec1de53289c8c99a0feecd4 100644
> > > --- a/src/responder/common/responder_get_domains.c
> > > +++ b/src/responder/common/responder_get_domains.c
> > > @@ -29,7 +29,7 @@ static DBusMessage *sss_dp_get_domains_msg(void *pvt);
> > > struct sss_dp_domains_info {
> > > struct sss_domain_info *dom;
> > > const char *hint;
> > > - bool force;
> > > + dbus_bool_t force;
> > > };
> > >
> > > static struct tevent_req *
> > > @@ -55,7 +55,7 @@ get_subdomains_send(TALLOC_CTX *mem_ctx, struct resp_ctx
*rctx,
> > > goto fail;
> > > }
> > > info->hint = hint;
> > > - info->force = force;
> > > + info->force = force ? TRUE : FALSE;
> >
> > wow, good catch, but please add a comment to avoid "optimizations"
in
> > future.
> >
> > bye,
> > Sumit
>
> Well, there was a DBus assert-like error message that made my life
> easier.
>
> Sure, new patch with a comment is attached.
ACK
Simo.