URL: https://github.com/SSSD/sssd/pull/757 Author: thalman Title: #757: krb5_locator: Allow hostname in kdcinfo files Action: opened
PR body: """ Currently we support only IP addresses in kdcinfo files. We need to resolv eventual dns name and then we have to iterate trough list of addresses because hostname can be resolved that way, including IPv4 and IPv6 addresses.
Resolves part of: https://pagure.io/fork/jhrozek/SSSD/docs/blob/ \ 9cd7240a6b9de5ef1d41a21dc04adfdd4b143c93/f/ \ design_pages/kdcinfo_multiple_servers.rst """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/757/head:pr757 git checkout pr757
URL: https://github.com/SSSD/sssd/pull/757 Title: #757: krb5_locator: Allow hostname in kdcinfo files
jhrozek commented: """ btw I filed https://pagure.io/SSSD/sssd/issue/3973 to track this part of the effort """
See the full comment at https://github.com/SSSD/sssd/pull/757#issuecomment-468275269
URL: https://github.com/SSSD/sssd/pull/757 Title: #757: krb5_locator: Allow hostname in kdcinfo files
sumit-bose commented: """ @thalman, can you rebase your patch on top of current master? """
See the full comment at https://github.com/SSSD/sssd/pull/757#issuecomment-468566149
URL: https://github.com/SSSD/sssd/pull/757 Author: thalman Title: #757: krb5_locator: Allow hostname in kdcinfo files Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/757/head:pr757 git checkout pr757
URL: https://github.com/SSSD/sssd/pull/757 Title: #757: krb5_locator: Allow hostname in kdcinfo files
sumit-bose commented: """ Hi Tomas,
please see my inline comments. Additionally please do a rebase not a merge so that your patch is the topmost commit and there is no merge commit. Please add to like to the pagure ticket instead of the design page to the commit message and add a comment to the man page for the plugin which explains the new feature.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/757#issuecomment-468684186
URL: https://github.com/SSSD/sssd/pull/757 Author: thalman Title: #757: krb5_locator: Allow hostname in kdcinfo files Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/757/head:pr757 git checkout pr757
URL: https://github.com/SSSD/sssd/pull/757 Author: thalman Title: #757: krb5_locator: Allow hostname in kdcinfo files Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/757/head:pr757 git checkout pr757
URL: https://github.com/SSSD/sssd/pull/757 Title: #757: krb5_locator: Allow hostname in kdcinfo files
thalman commented: """ Hi @sumit-bose
Thank you for the review, I updated PR according comments, Also I find out that one man-page should be also updated so it is included in PR now too.
Tom """
See the full comment at https://github.com/SSSD/sssd/pull/757#issuecomment-469179567
URL: https://github.com/SSSD/sssd/pull/757 Author: thalman Title: #757: krb5_locator: Allow hostname in kdcinfo files Action: edited
Changed field: body Original value: """ Currently we support only IP addresses in kdcinfo files. We need to resolv eventual dns name and then we have to iterate trough list of addresses because hostname can be resolved that way, including IPv4 and IPv6 addresses.
Resolves part of: https://pagure.io/fork/jhrozek/SSSD/docs/blob/ \ 9cd7240a6b9de5ef1d41a21dc04adfdd4b143c93/f/ \ design_pages/kdcinfo_multiple_servers.rst """
URL: https://github.com/SSSD/sssd/pull/757 Title: #757: krb5_locator: Allow hostname in kdcinfo files
jhrozek commented: """ A total nitpick, but you'll probably want to add resolves https://pagure.io/SSSD/sssd/issue/3973 and if you want to point to the design page, I've rendered it at https://docs.pagure.org/SSSD.sssd/design_pages/kdcinfo_multiple_servers.html """
See the full comment at https://github.com/SSSD/sssd/pull/757#issuecomment-470843434
URL: https://github.com/SSSD/sssd/pull/757 Title: #757: krb5_locator: Allow hostname in kdcinfo files
thalman commented: """
A total nitpick, but you'll probably want to add resolves https://pagure.io/SSSD/sssd/issue/3973 and if you want
This has been fixed with rebase requested by Sumit
"""
See the full comment at https://github.com/SSSD/sssd/pull/757#issuecomment-472307358
URL: https://github.com/SSSD/sssd/pull/757 Title: #757: krb5_locator: Allow hostname in kdcinfo files
sumit-bose commented: """ Hi @thalman,
thank you for the new version. It looks good now except the minor nitpick I added inline. Would you mind to fix this as well?
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/757#issuecomment-472973751
URL: https://github.com/SSSD/sssd/pull/757 Author: thalman Title: #757: krb5_locator: Allow hostname in kdcinfo files Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/757/head:pr757 git checkout pr757
URL: https://github.com/SSSD/sssd/pull/757 Title: #757: krb5_locator: Allow hostname in kdcinfo files
thalman commented: """ @jhrozek, @sumit-bose PR updated """
See the full comment at https://github.com/SSSD/sssd/pull/757#issuecomment-473221787
URL: https://github.com/SSSD/sssd/pull/757 Title: #757: krb5_locator: Allow hostname in kdcinfo files
sumit-bose commented: """ Thanks, ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/757#issuecomment-473229582
URL: https://github.com/SSSD/sssd/pull/757 Title: #757: krb5_locator: Allow hostname in kdcinfo files
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/757 Title: #757: krb5_locator: Allow hostname in kdcinfo files
jhrozek commented: """ master: 63ccbfe sssd-1-16: 96e4d71
"""
See the full comment at https://github.com/SSSD/sssd/pull/757#issuecomment-474613613
URL: https://github.com/SSSD/sssd/pull/757 Author: thalman Title: #757: krb5_locator: Allow hostname in kdcinfo files Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/757/head:pr757 git checkout pr757
URL: https://github.com/SSSD/sssd/pull/757 Title: #757: krb5_locator: Allow hostname in kdcinfo files
Label: +Pushed
sssd-devel@lists.fedorahosted.org