Currently the default is the same as it used to. Shall I also change the default? I know there are already people using the trusts out there, so I didn't want to disrupt their environment.
On 04/04/2013 01:46 PM, Jakub Hrozek wrote:
Currently the default is the same as it used to. Shall I also change the default? I know there are already people using the trusts out there, so I didn't want to disrupt their environment.
Man page nack.
When %F makes sense only for subdomain_homedir, I think we should move the description there.
Also override_homedir in sssd-ad is missing %o, which I think is a mistake. Anyway, is there any particular reason why this option is described in sssd-ad? If yes, we should create a shared file and include it instead of maintaining it on two placed.
Otherwise is seems to be working.
On Mon, Apr 08, 2013 at 03:44:31PM +0200, Pavel Březina wrote:
On 04/04/2013 01:46 PM, Jakub Hrozek wrote:
Currently the default is the same as it used to. Shall I also change the default? I know there are already people using the trusts out there, so I didn't want to disrupt their environment.
Man page nack.
When %F makes sense only for subdomain_homedir, I think we should move the description there.
OK, I was deciding between the two as well.
Also override_homedir in sssd-ad is missing %o, which I think is a mistake. Anyway, is there any particular reason why this option is described in sssd-ad?
It was specifically requested: https://fedorahosted.org/sssd/ticket/1433
If yes, we should create a shared file and include it instead of maintaining it on two placed.
Otherwise is seems to be working.
New patches are attached. Patch #1 splits the override_homedir into an include file and patch #2 adds the new option.
On 04/08/2013 11:07 PM, Jakub Hrozek wrote:
On Mon, Apr 08, 2013 at 03:44:31PM +0200, Pavel Březina wrote:
On 04/04/2013 01:46 PM, Jakub Hrozek wrote:
Currently the default is the same as it used to. Shall I also change the default? I know there are already people using the trusts out there, so I didn't want to disrupt their environment.
Man page nack.
When %F makes sense only for subdomain_homedir, I think we should move the description there.
OK, I was deciding between the two as well.
Also override_homedir in sssd-ad is missing %o, which I think is a mistake. Anyway, is there any particular reason why this option is described in sssd-ad?
It was specifically requested: https://fedorahosted.org/sssd/ticket/1433
If yes, we should create a shared file and include it instead of maintaining it on two placed.
Otherwise is seems to be working.
New patches are attached. Patch #1 splits the override_homedir into an include file and patch #2 adds the new option.
Ack to both.
On Wed, Apr 10, 2013 at 10:48:54AM +0200, Pavel Březina wrote:
On 04/08/2013 11:07 PM, Jakub Hrozek wrote:
On Mon, Apr 08, 2013 at 03:44:31PM +0200, Pavel Březina wrote:
On 04/04/2013 01:46 PM, Jakub Hrozek wrote:
Currently the default is the same as it used to. Shall I also change the default? I know there are already people using the trusts out there, so I didn't want to disrupt their environment.
Man page nack.
When %F makes sense only for subdomain_homedir, I think we should move the description there.
OK, I was deciding between the two as well.
Also override_homedir in sssd-ad is missing %o, which I think is a mistake. Anyway, is there any particular reason why this option is described in sssd-ad?
It was specifically requested: https://fedorahosted.org/sssd/ticket/1433
If yes, we should create a shared file and include it instead of maintaining it on two placed.
Otherwise is seems to be working.
New patches are attached. Patch #1 splits the override_homedir into an include file and patch #2 adds the new option.
Ack to both.
Thanks for the review, pushed both to master.
sssd-devel@lists.fedorahosted.org