URL: https://github.com/SSSD/sssd/pull/5316 Author: luizluca Title: #5316: SSSCTL: fix logs-remove when log directory is empty Action: opened
PR body: """ "sssctl logs-remove" calls "truncate --size 0 *.log" and "*.log" will expand to literal '*.log' when directory is empty. The result is a new empty '*.log' file.
Add '--no-create' to truncate call.
Signed-off-by: Luiz Angelo Daros de Luca luizluca@gmail.com """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5316/head:pr5316 git checkout pr5316
URL: https://github.com/SSSD/sssd/pull/5316 Title: #5316: SSSCTL: fix logs-remove when log directory is empty
sumit-bose commented: """ Hi,
good catch and thank you for the patch. I'm fine with the change, @pbrezina, do you agree as well?
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5316#issuecomment-693173613
URL: https://github.com/SSSD/sssd/pull/5316 Title: #5316: SSSCTL: fix logs-remove when log directory is empty
pbrezina commented: """ Ack. """
See the full comment at https://github.com/SSSD/sssd/pull/5316#issuecomment-694793702
URL: https://github.com/SSSD/sssd/pull/5316 Title: #5316: SSSCTL: fix logs-remove when log directory is empty
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5316 Title: #5316: SSSCTL: fix logs-remove when log directory is empty
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5316 Title: #5316: SSSCTL: fix logs-remove when log directory is empty
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5316
* `master` * cf15e9eac653ee4a2d3eeed28e5fd25a299f85fb - SSSCTL: fix logs-remove when log directory is empty
"""
See the full comment at https://github.com/SSSD/sssd/pull/5316#issuecomment-696013938
URL: https://github.com/SSSD/sssd/pull/5316 Title: #5316: SSSCTL: fix logs-remove when log directory is empty
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5316 Title: #5316: SSSCTL: fix logs-remove when log directory is empty
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5316 Title: #5316: SSSCTL: fix logs-remove when log directory is empty
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5316 Author: luizluca Title: #5316: SSSCTL: fix logs-remove when log directory is empty Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5316/head:pr5316 git checkout pr5316
sssd-devel@lists.fedorahosted.org
-
luizluca -
pbrezina
-
sumit-bose