On (08/06/16 15:54), Pavel Březina wrote:
On 06/08/2016 03:12 PM, Jakub Hrozek wrote:
Hi,
I found this little bug when reviewing Pavel's sudo patch.
Nice :D Obvious ack.
master: * 06f9759563f4581981046208cce8ebccaa603e01
sssd-1-13: * d9ccb66522adcf9fbbe3772a7b712e6bdcb2ad46
LS
On (09/06/16 12:06), Jakub Hrozek wrote:
On Thu, Jun 09, 2016 at 10:37:19AM +0200, Lukas Slebodnik wrote:
sssd-1-13:
- d9ccb66522adcf9fbbe3772a7b712e6bdcb2ad46
Unfortunately the debug macro doesn't seem to be in sssd-1-13, can we revert the patch from that branch?
What about removing just usage of this debug macro?
LS
On Thu, Jun 09, 2016 at 12:20:25PM +0200, Lukas Slebodnik wrote:
On (09/06/16 12:06), Jakub Hrozek wrote:
On Thu, Jun 09, 2016 at 10:37:19AM +0200, Lukas Slebodnik wrote:
sssd-1-13:
- d9ccb66522adcf9fbbe3772a7b712e6bdcb2ad46
Unfortunately the debug macro doesn't seem to be in sssd-1-13, can we revert the patch from that branch?
What about removing just usage of this debug macro?
LS
Yes, or just use plain DEBUG macro in 1.13?
On (09/06/16 12:25), Jakub Hrozek wrote:
On Thu, Jun 09, 2016 at 12:20:25PM +0200, Lukas Slebodnik wrote:
On (09/06/16 12:06), Jakub Hrozek wrote:
On Thu, Jun 09, 2016 at 10:37:19AM +0200, Lukas Slebodnik wrote:
sssd-1-13:
- d9ccb66522adcf9fbbe3772a7b712e6bdcb2ad46
Unfortunately the debug macro doesn't seem to be in sssd-1-13, can we revert the patch from that branch?
What about removing just usage of this debug macro?
LS
Yes, or just use plain DEBUG macro in 1.13?
state->cr does not esixt in 1.13 either.
So I'm not sure what shoudl be logged. Feel free to propose something (== send patch :-)
LS
On Thu, Jun 09, 2016 at 12:28:51PM +0200, Lukas Slebodnik wrote:
On (09/06/16 12:25), Jakub Hrozek wrote:
On Thu, Jun 09, 2016 at 12:20:25PM +0200, Lukas Slebodnik wrote:
On (09/06/16 12:06), Jakub Hrozek wrote:
On Thu, Jun 09, 2016 at 10:37:19AM +0200, Lukas Slebodnik wrote:
sssd-1-13:
- d9ccb66522adcf9fbbe3772a7b712e6bdcb2ad46
Unfortunately the debug macro doesn't seem to be in sssd-1-13, can we revert the patch from that branch?
What about removing just usage of this debug macro?
LS
Yes, or just use plain DEBUG macro in 1.13?
state->cr does not esixt in 1.13 either.
So I'm not sure what shoudl be logged. Feel free to propose something (== send patch :-)
OK, in that case, your patch that just removes the log message seems like the best solution.
On (09/06/16 13:02), Jakub Hrozek wrote:
On Thu, Jun 09, 2016 at 12:28:51PM +0200, Lukas Slebodnik wrote:
On (09/06/16 12:25), Jakub Hrozek wrote:
On Thu, Jun 09, 2016 at 12:20:25PM +0200, Lukas Slebodnik wrote:
On (09/06/16 12:06), Jakub Hrozek wrote:
On Thu, Jun 09, 2016 at 10:37:19AM +0200, Lukas Slebodnik wrote:
sssd-1-13:
- d9ccb66522adcf9fbbe3772a7b712e6bdcb2ad46
Unfortunately the debug macro doesn't seem to be in sssd-1-13, can we revert the patch from that branch?
What about removing just usage of this debug macro?
LS
Yes, or just use plain DEBUG macro in 1.13?
state->cr does not esixt in 1.13 either.
So I'm not sure what shoudl be logged. Feel free to propose something (== send patch :-)
OK, in that case, your patch that just removes the log message seems like the best solution.
http://sssd-ci.duckdns.org/logs/job/45/05/summary.html
sssd-1-13: * 08554bf194d0af50ec31e668155fef59cfcf24ac
Sorry for troubles.
LS
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Lukas Slebodnik -
Pavel Březina