On 01/25/2016 04:05 PM, Lukas Slebodnik wrote:
On (25/01/16 15:00), Nikolai Kondrashov wrote:
> Hi everyone,
> Our integration tests are leaving the temporary build directory after failing
> runs. This patch fixes that.
>From 7328e022f5379a8d242a3f88d4392fd5004cd777 Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov <Nikolai.Kondrashov(a)redhat.com>
> Date: Fri, 22 Jan 2016 15:52:18 +0200
> Subject: [PATCH] BUILD: Always remove integration test root
> Remove integration test installation prefix directory in a shell trap,
> within Makefile.am, instead of just at the end of the script. This makes
> it execute always, regardless if the script has aborted due to
> whatever failure (including test failure), or not.
> Otherwise "make intgcheck" was leaving the temporary directory under
> /tmp after the run.
if you decide to make an order with clean-up in integration test then
it will be good to move clean-up of log files from src/tests/intg/Makefile.am
Right, I think this is a wrong fix altogether and the original code was OK. I
didn't think it through well enough. We need those files for troubleshooting
in case of failure. The src/tests/intg/Makefile.am cleanup is for cleaning
between runs of intgcheck-installed, and I think should be left there.
Final cleanup should be done in the server CI setup, *after* uploading any
files which might be of use from there.
Please ignore this patch, if you agree.
Sorry for the noise.