URL: https://github.com/SSSD/sssd/pull/929 Author: pbrezina Title: #929: failover: make sure we switch to anoter server if only port differs Action: opened
PR body: """ This is a regression introduced in 735af71a8e169f17fa5462db610a1567c9618e29. After this commit we checked only server name instead of name and port combo.
Steps to reproduce: 1. Configure SSSD to use two servers with same name but different ports ``` [domain/LDAP] debug_level=0xFFF0 id_provider = ldap ldap_uri = ldap://$SERVER1:12345,ldap://$SERVER1:389 ldap_tls_cacertdir = /etc/openldap/certs ldap_search_base = dc=example,dc=com ```
2. The first server port is unreachable, the second is working. 3. Run sssd and try to resolve user. 4. Without the patch SSSD tries to connect to the first server twice because new URI is not constructed and goes offline.
Resolves: https://pagure.io/SSSD/sssd/issue/4112 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/929/head:pr929 git checkout pr929
URL: https://github.com/SSSD/sssd/pull/929 Title: #929: failover: make sure we switch to anoter server if only port differs
mzidek-rh commented: """ I plan to review this today. """
See the full comment at https://github.com/SSSD/sssd/pull/929#issuecomment-550257641
URL: https://github.com/SSSD/sssd/pull/929 Title: #929: failover: make sure we switch to anoter server if only port differs
mzidek-rh commented: """ Works for me. Code looks good.
ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/929#issuecomment-550565106
URL: https://github.com/SSSD/sssd/pull/929 Title: #929: failover: make sure we switch to anoter server if only port differs
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/929 Title: #929: failover: make sure we switch to anoter server if only port differs
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/929 Title: #929: failover: make sure we switch to anoter server if only port differs
pbrezina commented: """ * `master` * 08f0159078aa00d04533ca227679e25d64c452e1 - failover: make sure we switch to anoter server if only port differs
"""
See the full comment at https://github.com/SSSD/sssd/pull/929#issuecomment-551055432
URL: https://github.com/SSSD/sssd/pull/929 Title: #929: failover: make sure we switch to anoter server if only port differs
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/929 Title: #929: failover: make sure we switch to anoter server if only port differs
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/929 Title: #929: failover: make sure we switch to anoter server if only port differs
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/929 Author: pbrezina Title: #929: failover: make sure we switch to anoter server if only port differs Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/929/head:pr929 git checkout pr929
sssd-devel@lists.fedorahosted.org