ehlo,
We should set pagging flag in state and not in local variable which is not read anywhere in the function.
Found by clang static analyzer.
Do we need this patch also to stable branch?
LS
On Tue, Aug 30, 2016 at 5:26 PM, Lukas Slebodnik lslebodn@redhat.com wrote:
ehlo,
We should set pagging flag in state and not in local variable which is not read anywhere in the function.
Found by clang static analyzer.
Do we need this patch also to stable branch?
LS
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
Acked-by: Fabiano Fidêncio fidencio@redhat.com
On (31/08/16 07:45), Fabiano Fidêncio wrote:
On Tue, Aug 30, 2016 at 5:26 PM, Lukas Slebodnik lslebodn@redhat.com wrote:
ehlo,
We should set pagging flag in state and not in local variable which is not read anywhere in the function.
Found by clang static analyzer.
Do we need this patch also to stable branch?
LS
Acked-by: Fabiano Fidêncio fidencio@redhat.com
Thank you for review.
But I would like to know what other developers think about backporting this patch to stable branch.
LS
On Fri, Sep 09, 2016 at 12:48:47PM +0200, Lukas Slebodnik wrote:
On (31/08/16 07:45), Fabiano Fidêncio wrote:
On Tue, Aug 30, 2016 at 5:26 PM, Lukas Slebodnik lslebodn@redhat.com wrote:
ehlo,
We should set pagging flag in state and not in local variable which is not read anywhere in the function.
Found by clang static analyzer.
Do we need this patch also to stable branch?
LS
Acked-by: Fabiano Fidêncio fidencio@redhat.com
Thank you for review.
But I would like to know what other developers think about backporting this patch to stable branch.
The old code is really wrong and the patch is quite simple and touches only a single function, so I don't mind backporting it, so ACK.
Nevertherless I think the chances are quite low that the old code might cause issues. It looks like the deref/asq code paths already set the flag. And according to https://fedorahosted.org/sssd/ticket/1202 paging is disabled for base searches to not consume unneeded resources on the server side, but I'm not aware of related bug reports although the old code is around since some time.
bye, Sumit
LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
On (09/09/16 13:09), Sumit Bose wrote:
On Fri, Sep 09, 2016 at 12:48:47PM +0200, Lukas Slebodnik wrote:
On (31/08/16 07:45), Fabiano Fidêncio wrote:
On Tue, Aug 30, 2016 at 5:26 PM, Lukas Slebodnik lslebodn@redhat.com wrote:
ehlo,
We should set pagging flag in state and not in local variable which is not read anywhere in the function.
Found by clang static analyzer.
Do we need this patch also to stable branch?
LS
Acked-by: Fabiano Fidêncio fidencio@redhat.com
Thank you for review.
But I would like to know what other developers think about backporting this patch to stable branch.
The old code is really wrong and the patch is quite simple and touches only a single function, so I don't mind backporting it, so ACK.
Nevertherless I think the chances are quite low that the old code might cause issues. It looks like the deref/asq code paths already set the flag. And according to https://fedorahosted.org/sssd/ticket/1202 paging is disabled for base searches to not consume unneeded resources on the server side, but I'm not aware of related bug reports although the old code is around since some time.
master: * 6c335dee38da943796710b5e336472a10cf641f2
sssd-1-13: * d8cf127e988f19f66e00d40b127e488973376ef9
LS
sssd-devel@lists.fedorahosted.org
-
Fabiano Fidêncio -
Lukas Slebodnik -
Sumit Bose