I had a couple of minutes before a meeting starts, so I squashed away these two man page tickets.
On 04/18/2013 02:20 PM, Jakub Hrozek wrote:
diff --git a/src/man/sssd-ad.5.xml b/src/man/sssd-ad.5.xml index 6ab133d5204fb2adcb65bafb33e8242a5afcaa70..cfd03b8d30eaf8ad6bb8c333119dc6df8ff381d8 100644 --- a/src/man/sssd-ad.5.xml +++ b/src/man/sssd-ad.5.xml @@ -68,6 +68,7 @@ <programlisting> ldap_id_mapping = False </programlisting>
The AD provider is also case-insensitive by default.
I think it would be better to say, that AD provider is "always" case insensitive (not just "by default").
Michal
On Thu, Apr 18, 2013 at 03:38:34PM +0200, Michal Židek wrote:
On 04/18/2013 02:20 PM, Jakub Hrozek wrote:
diff --git a/src/man/sssd-ad.5.xml b/src/man/sssd-ad.5.xml index 6ab133d5204fb2adcb65bafb33e8242a5afcaa70..cfd03b8d30eaf8ad6bb8c333119dc6df8ff381d8 100644 --- a/src/man/sssd-ad.5.xml +++ b/src/man/sssd-ad.5.xml @@ -68,6 +68,7 @@ <programlisting> ldap_id_mapping = False </programlisting>
The AD provider is also case-insensitive by default.
I think it would be better to say, that AD provider is "always" case insensitive (not just "by default").
Michal
I agree, new patches attached.
On 04/19/2013 03:42 PM, Jakub Hrozek wrote:
A domain name should only consist of alphanumeric
characters, dashes and underscores.
One more nitpick. Instead of just "alphanumeric characters" it might be better to use "ASCII alphanumeric characters", so that it is clear, that locale specific alphanumeric characters are not supported.
Sorry for not catching this in the first iteration.
Michal
On Tue, Apr 23, 2013 at 02:30:48PM +0200, Michal Židek wrote:
On 04/19/2013 03:42 PM, Jakub Hrozek wrote:
A domain name should only consist of alphanumeric
characters, dashes and underscores.
One more nitpick. Instead of just "alphanumeric characters" it might be better to use "ASCII alphanumeric characters", so that it is clear, that locale specific alphanumeric characters are not supported.
Sorry for not catching this in the first iteration.
Michal
Thanks for the review, new patches are attached.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 04/18/2013 09:38 AM, Michal Židek wrote:
On 04/18/2013 02:20 PM, Jakub Hrozek wrote:
diff --git a/src/man/sssd-ad.5.xml b/src/man/sssd-ad.5.xml index 6ab133d5204fb2adcb65bafb33e8242a5afcaa70..cfd03b8d30eaf8ad6bb8c333119dc6df8ff381d8
100644
--- a/src/man/sssd-ad.5.xml +++ b/src/man/sssd-ad.5.xml @@ -68,6 +68,7 @@ <programlisting> ldap_id_mapping = False </programlisting> + The AD provider is also case-insensitive by default.
I think it would be better to say, that AD provider is "always" case insensitive (not just "by default").
As a native speaker, I'd suggest that this would read better as
"Users, groups and other entities served by SSSD are always treated as case-insensitive in the AD provider for compatibility with Active Directory's LDAP implementation."
It provides a little more information (so people don't have to go looking for the case-sensitivity section of the docs).
On Tue, Apr 23, 2013 at 11:40:38AM -0400, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 04/18/2013 09:38 AM, Michal Židek wrote:
On 04/18/2013 02:20 PM, Jakub Hrozek wrote:
diff --git a/src/man/sssd-ad.5.xml b/src/man/sssd-ad.5.xml index 6ab133d5204fb2adcb65bafb33e8242a5afcaa70..cfd03b8d30eaf8ad6bb8c333119dc6df8ff381d8
100644
--- a/src/man/sssd-ad.5.xml +++ b/src/man/sssd-ad.5.xml @@ -68,6 +68,7 @@ <programlisting> ldap_id_mapping = False </programlisting> + The AD provider is also case-insensitive by default.
I think it would be better to say, that AD provider is "always" case insensitive (not just "by default").
As a native speaker, I'd suggest that this would read better as
"Users, groups and other entities served by SSSD are always treated as case-insensitive in the AD provider for compatibility with Active Directory's LDAP implementation."
It provides a little more information (so people don't have to go looking for the case-sensitivity section of the docs).
Thanks for the suggestion, new patches are attached.
On 04/24/2013 08:57 PM, Jakub Hrozek wrote:
On Tue, Apr 23, 2013 at 11:40:38AM -0400, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 04/18/2013 09:38 AM, Michal Židek wrote:
On 04/18/2013 02:20 PM, Jakub Hrozek wrote:
diff --git a/src/man/sssd-ad.5.xml b/src/man/sssd-ad.5.xml index 6ab133d5204fb2adcb65bafb33e8242a5afcaa70..cfd03b8d30eaf8ad6bb8c333119dc6df8ff381d8
100644
--- a/src/man/sssd-ad.5.xml +++ b/src/man/sssd-ad.5.xml @@ -68,6 +68,7 @@ <programlisting> ldap_id_mapping = False </programlisting> + The AD provider is also case-insensitive by default.
I think it would be better to say, that AD provider is "always" case insensitive (not just "by default").
As a native speaker, I'd suggest that this would read better as
"Users, groups and other entities served by SSSD are always treated as case-insensitive in the AD provider for compatibility with Active Directory's LDAP implementation."
It provides a little more information (so people don't have to go looking for the case-sensitivity section of the docs).
Thanks for the suggestion, new patches are attached.
The wording looks good to me and man pages build fine with these patches.
Ack!
Michal
On Thu, Apr 25, 2013 at 02:09:43PM +0200, Michal Židek wrote:
On 04/24/2013 08:57 PM, Jakub Hrozek wrote:
On Tue, Apr 23, 2013 at 11:40:38AM -0400, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 04/18/2013 09:38 AM, Michal Židek wrote:
On 04/18/2013 02:20 PM, Jakub Hrozek wrote:
diff --git a/src/man/sssd-ad.5.xml b/src/man/sssd-ad.5.xml index 6ab133d5204fb2adcb65bafb33e8242a5afcaa70..cfd03b8d30eaf8ad6bb8c333119dc6df8ff381d8
100644
--- a/src/man/sssd-ad.5.xml +++ b/src/man/sssd-ad.5.xml @@ -68,6 +68,7 @@ <programlisting> ldap_id_mapping = False </programlisting> + The AD provider is also case-insensitive by default.
I think it would be better to say, that AD provider is "always" case insensitive (not just "by default").
As a native speaker, I'd suggest that this would read better as
"Users, groups and other entities served by SSSD are always treated as case-insensitive in the AD provider for compatibility with Active Directory's LDAP implementation."
It provides a little more information (so people don't have to go looking for the case-sensitivity section of the docs).
Thanks for the suggestion, new patches are attached.
The wording looks good to me and man pages build fine with these patches.
Ack!
Michal
Thanks for the review.
Pushed to master.
sssd-devel@lists.fedorahosted.org