URL: https://github.com/SSSD/sssd/pull/818 Author: sumit-bose Title: #818: DP: add NULL check to be_ptask_{enable|disable} Action: opened
PR body: """ Currently the files and the proxy provider do not provide a check online method (DPM_CHECK_ONLINE). The files provider because it can never go offline. The proxy provider because there is no generic way to check since the nature of the actual provider is unknown.
Since the method is missing check_if_online() jumps into the error handling block were we try to reset the offline state unconditionally. If there is no check_if_online_ptask, which never exists for the files provider and will not be available in the proxy provider as long as the backend is online, be_ptask_{enable|disable} will be called with a NULL pointer.
Related to https://pagure.io/SSSD/sssd/issue/4014 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/818/head:pr818 git checkout pr818
URL: https://github.com/SSSD/sssd/pull/818 Title: #818: DP: add NULL check to be_ptask_{enable|disable}
jhrozek commented: """ @thalman Hi Tomas, sorry I didn't clone and assign the bug to you earlier, but I wonder if you can look at the patch and review it? """
See the full comment at https://github.com/SSSD/sssd/pull/818#issuecomment-495576563
URL: https://github.com/SSSD/sssd/pull/818 Title: #818: DP: add NULL check to be_ptask_{enable|disable}
alexey-tikhonov commented: """ Honestly, I would prefer ``` if (!task) { return; } ``` instead of wrapping whole function content into `if (task != NULL) {}` At least `diff` would be smaller.
Otherwise ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/818#issuecomment-495613816
URL: https://github.com/SSSD/sssd/pull/818 Title: #818: DP: add NULL check to be_ptask_{enable|disable}
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/818 Title: #818: DP: add NULL check to be_ptask_{enable|disable}
jhrozek commented: """ * master: 2720d97 * sssd-1-16: cb94d00
"""
See the full comment at https://github.com/SSSD/sssd/pull/818#issuecomment-496660665
URL: https://github.com/SSSD/sssd/pull/818 Author: sumit-bose Title: #818: DP: add NULL check to be_ptask_{enable|disable} Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/818/head:pr818 git checkout pr818
URL: https://github.com/SSSD/sssd/pull/818 Title: #818: DP: add NULL check to be_ptask_{enable|disable}
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
jhrozek
-
sumit-bose