Hi list,
how Jakub mentioned on internal list this debug message should be removed. So I attached simple patch for it.
Regards
On Mon, Jul 11, 2016 at 09:49:15AM -0400, Stephen Gallagher wrote:
On 07/11/2016 09:33 AM, Petr Cech wrote:
Hi list,
how Jakub mentioned on internal list this debug message should be removed. So I attached simple patch for it.
I'd recommend changing it to "Trace: end of ldap_result list" rather than deleting it.
In addition, can you also link https://fedorahosted.org/sssd/ticket/3091 to the patch in the commit message? I've seen someone again being confused by the error message this week, that's why I filed the ticket in the first place.
(and #3090 is a similar ticket although I'm not sure if you're familiar with the IPA subdomains code..)
On 07/11/2016 08:22 PM, Jakub Hrozek wrote:
On Mon, Jul 11, 2016 at 09:49:15AM -0400, Stephen Gallagher wrote:
On 07/11/2016 09:33 AM, Petr Cech wrote:
Hi list,
how Jakub mentioned on internal list this debug message should be removed. So I attached simple patch for it.
I'd recommend changing it to "Trace: end of ldap_result list" rather than deleting it.
Sure, this is better solution. Thanks, Stephen. I looked at the code and it makes sense to me.
In addition, can you also link https://fedorahosted.org/sssd/ticket/3091 to the patch in the commit message? I've seen someone again being confused by the error message this week, that's why I filed the ticket in the first place.
I linked the ticket.
(and #3090 is a similar ticket although I'm not sure if you're familiar with the IPA subdomains code..)
New version is attached.
Regards
On 07/12/2016 03:40 AM, Petr Cech wrote:
On 07/11/2016 08:22 PM, Jakub Hrozek wrote:
On Mon, Jul 11, 2016 at 09:49:15AM -0400, Stephen Gallagher wrote:
On 07/11/2016 09:33 AM, Petr Cech wrote:
Hi list,
how Jakub mentioned on internal list this debug message should be removed. So I attached simple patch for it.
I'd recommend changing it to "Trace: end of ldap_result list" rather than deleting it.
Sure, this is better solution. Thanks, Stephen. I looked at the code and it makes sense to me.
In addition, can you also link https://fedorahosted.org/sssd/ticket/3091 to the patch in the commit message? I've seen someone again being confused by the error message this week, that's why I filed the ticket in the first place.
I linked the ticket.
(and #3090 is a similar ticket although I'm not sure if you're familiar with the IPA subdomains code..)
New version is attached.
Regards
Ack
On 07/22/2016 02:20 PM, Stephen Gallagher wrote:
On 07/12/2016 03:40 AM, Petr Cech wrote:
On 07/11/2016 08:22 PM, Jakub Hrozek wrote:
On Mon, Jul 11, 2016 at 09:49:15AM -0400, Stephen Gallagher wrote:
On 07/11/2016 09:33 AM, Petr Cech wrote:
Hi list,
how Jakub mentioned on internal list this debug message should be removed. So I attached simple patch for it.
I'd recommend changing it to "Trace: end of ldap_result list" rather than deleting it.
Sure, this is better solution. Thanks, Stephen. I looked at the code and it makes sense to me.
In addition, can you also link https://fedorahosted.org/sssd/ticket/3091 to the patch in the commit message? I've seen someone again being confused by the error message this week, that's why I filed the ticket in the first place.
I linked the ticket.
(and #3090 is a similar ticket although I'm not sure if you're familiar with the IPA subdomains code..)
New version is attached.
Regards
Ack
Stephen, thank you for review. :-)
On (22/07/16 08:20), Stephen Gallagher wrote:
On 07/12/2016 03:40 AM, Petr Cech wrote:
On 07/11/2016 08:22 PM, Jakub Hrozek wrote:
On Mon, Jul 11, 2016 at 09:49:15AM -0400, Stephen Gallagher wrote:
On 07/11/2016 09:33 AM, Petr Cech wrote:
Hi list,
how Jakub mentioned on internal list this debug message should be removed. So I attached simple patch for it.
I'd recommend changing it to "Trace: end of ldap_result list" rather than deleting it.
Sure, this is better solution. Thanks, Stephen. I looked at the code and it makes sense to me.
In addition, can you also link https://fedorahosted.org/sssd/ticket/3091 to the patch in the commit message? I've seen someone again being confused by the error message this week, that's why I filed the ticket in the first place.
I linked the ticket.
(and #3090 is a similar ticket although I'm not sure if you're familiar with the IPA subdomains code..)
New version is attached.
Regards
Ack
master: * 07faf35960fafcff07ef588a851bde0066e88cd7
LS
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Lukas Slebodnik -
Petr Cech -
Stephen Gallagher