-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Convert the example config to v2 format, upgrade config on update only
Also, instead of having an LDAP proxy domain as an example, show a native LDAP config.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/25/2009 10:50 AM, Jakub Hrozek wrote:
Convert the example config to v2 format, upgrade config on update only
Also, instead of having an LDAP proxy domain as an example, show a native LDAP config.
Nack
The changes to sssd.spec.in are unnecessary. The upgrade_config.py already does an internal check and bails out if the version is already matched.
There's trailing whitespace after min_id in [domains/AD] (and it still is [domains/AD] instead of [domain/AD]
- ------------------------------------------------------------------------
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
- -- Stephen Gallagher RHCE 804006346421761
Looking to carve out IT costs? www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/25/2009 05:12 PM, Stephen Gallagher wrote:
Nack
The changes to sssd.spec.in are unnecessary. The upgrade_config.py already does an internal check and bails out if the version is already matched.
I know there is a check in the script but I still think it is better to not run the script at all if we know we are installing and not upgrading. At least we don't output the "config file already v2" message while having the message in the script for manual runs.
Anyway, I reverted the change in the specfile
There's trailing whitespace after min_id in [domains/AD] (and it still is [domains/AD] instead of [domain/AD]
Thanks, fixed.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/25/2009 11:31 AM, Jakub Hrozek wrote:
On 09/25/2009 05:12 PM, Stephen Gallagher wrote:
Nack
The changes to sssd.spec.in are unnecessary. The upgrade_config.py already does an internal check and bails out if the version is already matched.
I know there is a check in the script but I still think it is better to not run the script at all if we know we are installing and not upgrading. At least we don't output the "config file already v2" message while having the message in the script for manual runs.
Anyway, I reverted the change in the specfile
Actually, I wish you hadn't reverted it. I forgot that it printed that message. I will merge that specfile change back in before committing.
There's trailing whitespace after min_id in [domains/AD] (and it still is [domains/AD] instead of [domain/AD]
Thanks, fixed.
- ------------------------------------------------------------------------
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
- -- Stephen Gallagher RHCE 804006346421761
Looking to carve out IT costs? www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/25/2009 12:15 PM, Stephen Gallagher wrote:
On 09/25/2009 11:31 AM, Jakub Hrozek wrote:
On 09/25/2009 05:12 PM, Stephen Gallagher wrote:
Nack
The changes to sssd.spec.in are unnecessary. The upgrade_config.py already does an internal check and bails out if the version is already matched.
I know there is a check in the script but I still think it is better to not run the script at all if we know we are installing and not upgrading. At least we don't output the "config file already v2" message while having the message in the script for manual runs.
Anyway, I reverted the change in the specfile
Actually, I wish you hadn't reverted it. I forgot that it printed that message. I will merge that specfile change back in before committing.
There's trailing whitespace after min_id in [domains/AD] (and it still is [domains/AD] instead of [domain/AD]
Thanks, fixed.
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
Merged the specfile change back in and pushed. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
- -- Stephen Gallagher RHCE 804006346421761
Looking to carve out IT costs? www.redhat.com/carveoutcosts/
sssd-devel@lists.fedorahosted.org