On Thu, Feb 28, 2013 at 02:15:10PM -0500, Simo Sorce wrote:
On Thu, 2013-02-28 at 20:01 +0100, Jakub Hrozek wrote:
> On Fri, Feb 22, 2013 at 04:05:42PM +0100, Stephen Gallagher wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > There is a large amount of duplicated code being linked into multiple
> > SSSD binaries. Instead of statically linking this code throughout the
> > SSSD, we should instead create private shared libraries for them and
> > drop this code on the system only once.
> > The installed size of the Fedora RPMs decreased from 13MB to 5.1MB.
> > This is definitely a significant gain, both in disk space and memory
> > usage (since the code will only need to be loaded into memory once).
> I tested the patch and it works fine for me. I tested LDAP, Kerberos and
> IPA backends -- all of them work fine as far as sanity testing (basic LDAP
> and auth) goes. All the libraries are built with -avoid-version which is
> correct. All of them are marked as pkglib which is correct given their fs
> location and the intent. Make, make check and make rpms work fine.
> So I'm giving ack but I don't feel quite confident to push right away. It
> would be nice if another developer more proficient with autotools would
> ack as well.
> Thanks for the patch! I'm sure that user of embedded systems would love
> the decrease in size.
Looks good to me too.
Thanks for the second look. Pushed to master.