On (22/05/14 17:41), Sumit Bose wrote:
On Thu, May 22, 2014 at 05:30:13PM +0200, Lukas Slebodnik wrote:
> On (21/05/14 20:04), Yassir Elley wrote:
> >Hi,
> >
> >The attached patch adds libsmbclient to the makefiles, in preparation
> >for adding libsmbclient calls to the gpo-smb code. This patch depends on
> >a previously submitted patch ("Add ad_gpo unit test"), which has not
yet been
> >pushed to master.
> >
> >Regards,
> >Yassir.
>
> >From 44a6a108855627beba5c2a3864af87330ecec849 Mon Sep 17 00:00:00 2001
> >From: Yassir Elley <yelley(a)redhat.com>
> >Date: Wed, 21 May 2014 19:58:52 -0400
> >Subject: [PATCH] AD-GPO: add libsmbclient to makefiles
> >
> >---
> > Makefile.am | 10 +++++++---
> > configure.ac | 1 +
> > src/external/libsmbclient.m4 | 5 +++++
> > 3 files changed, 13 insertions(+), 3 deletions(-)
> > create mode 100644 src/external/libsmbclient.m4
> >
> >diff --git a/Makefile.am b/Makefile.am
> >index
134163fee47a923808b866daed92453b147fd79d..48360ffd27ddc5b7e7d63ba130da1b9a4f18f093 100644
> >--- a/Makefile.am
> >+++ b/Makefile.am
> >@@ -1987,9 +1987,11 @@ libsss_ad_common_la_SOURCES = \
> > libsss_ad_common_la_LDFLAGS = \
> > -avoid-version
> > libsss_ad_common_la_CFLAGS = \
> >- $(NDR_NBT_CFLAGS)
> >+ $(NDR_NBT_CFLAGS) \
> >+ $(SMBCLIENT_CFLAGS)
> > libsss_ad_common_la_LIBADD = \
> >- $(NDR_NBT_LIBS)
> >+ $(NDR_NBT_LIBS) \
> >+ $(SMBCLIENT_LIBS)
> >
> > libsss_krb5_common_la_SOURCES = \
> > src/providers/krb5/krb5_utils.c \
> >@@ -2166,7 +2168,8 @@ libsss_ad_la_CFLAGS = \
^^^^^^^^^^^^^^^^^^^
I overlooked it
> > $(SASL_CFLAGS) \
> > $(DHASH_CFLAGS) \
> > $(KRB5_CFLAGS) \
> >- $(NDR_NBT_CFLAGS)
> >+ $(NDR_NBT_CFLAGS) \
> >+ $(SMBCLIENT_CFLAGS)
> I didn't test this patch, but I would like to know why this "general
purpose"
> library libsss_krb5_common.so need to have SMBCLIENT_CFLAGS.
> I will complicate building sssd without samba (without providers: ipa, ad)
If I read the patch correctly the changes are only applied to libsss_ad,
libsss_krb5_common is just context. But I have not applied the patch to
be sure.
Yes, you are right.
Sorry.
LS