On Mon, Jan 11, 2016 at 12:22:19PM +0100, Lukas Slebodnik wrote:
On (11/01/16 10:26), Jakub Hrozek wrote:
>On Wed, Jan 06, 2016 at 04:48:00PM +0100, Lukas Slebodnik wrote:
>> This change is required to reduce dependency tree in client
>> container (or on atomic host, ...)
>> Patch is attached.
>I have some questions..
>1) Why not just move the file ownership to sssd-common? Are you
>concerned that not everyone needs sudo and it would be an extra file on
It was in sssd-common but it should be moved outside.
I dnifn't notice I forgot to do that :-)
Ah, sorry, I meant sssd-client here, not sssd-common...since client
would have to be installed anyway in the containerized environments and
the size of the sudo package is just 20kBs..
>2) The src/sss_client/sudo/sss_sudo.c only lists GPLv3, not LGPLv3, are
>you sure adding the lesser copying is correct?
I didn't check header of file. I used the same license as in was in 1.9.x
>3) I think this is a good opportunity to move the library outside
>libdir, at least in F-24 (this would require coordination with sudo and
>adding versioned Requires)
They are unrelated changes and shoudl be discussed with sudo maintainer.
indeed it needs to be discussed, but isn't it a good time now when F-24
is in its early development.
BTW atm sssd-common(and thus libsss_sudo.so) does not depend on sudo.
Yes, but we would have to add a versioned dependency to the sudo side to
make sure the libsss_sudo it would pull would be the one that carries
the expected location of libsss_sudo..