On 07/13/2016 01:47 PM, Pavel Březina wrote:
0001-utils-add-remove_subtree.patch
From 0aa39a46b707212e6487b6b537238e31bf7da1b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 12:17:58 +0200 Subject: [PATCH 1/2] utils: add remove_subtree
Remove all entries in a directory but will not remove the directory itself.
^--- [1] ...
- if (!subtree) {
^--- Pavel, please, would you like to add the comment in meaning of [1] here. I needed spent time to understand that the code do what is expected.
ret = unlinkat(parent_fd, dir_name, AT_REMOVEDIR);
if (ret == -1) {
ret = errno;
}}
0002-sssctl-use-internal-API-to-remove-files.patch
From 6413cb17138d8b24d579109454ae5dd7049b552a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 13:29:54 +0200 Subject: [PATCH 2/2] sssctl: use internal API to remove files
CI passed: http://sssd-ci.duckdns.org/logs/job/50/90/summary.html
ACK (and please add the comment)
Regards
-- Petr^4 Čech
On 08/05/2016 01:48 PM, Petr Cech wrote:
On 07/13/2016 01:47 PM, Pavel Březina wrote:
0001-utils-add-remove_subtree.patch
From 0aa39a46b707212e6487b6b537238e31bf7da1b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 12:17:58 +0200 Subject: [PATCH 1/2] utils: add remove_subtree
Remove all entries in a directory but will not remove the directory itself.
^--- [1] ...
- if (!subtree) {
^---
Pavel, please, would you like to add the comment in meaning of [1] here. I needed spent time to understand that the code do what is expected.
ret = unlinkat(parent_fd, dir_name, AT_REMOVEDIR);
if (ret == -1) {
ret = errno;
}}
0002-sssctl-use-internal-API-to-remove-files.patch
From 6413cb17138d8b24d579109454ae5dd7049b552a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 13:29:54 +0200 Subject: [PATCH 2/2] sssctl: use internal API to remove files
CI passed: http://sssd-ci.duckdns.org/logs/job/50/90/summary.html
ACK (and please add the comment)
bump
Regards
On 08/09/2016 01:53 PM, Petr Cech wrote:
On 08/05/2016 01:48 PM, Petr Cech wrote:
On 07/13/2016 01:47 PM, Pavel Březina wrote:
0001-utils-add-remove_subtree.patch
From 0aa39a46b707212e6487b6b537238e31bf7da1b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 12:17:58 +0200 Subject: [PATCH 1/2] utils: add remove_subtree
Remove all entries in a directory but will not remove the directory itself.
^--- [1] ...
- if (!subtree) {
^---
Pavel, please, would you like to add the comment in meaning of [1] here. I needed spent time to understand that the code do what is expected.
ret = unlinkat(parent_fd, dir_name, AT_REMOVEDIR);
if (ret == -1) {
ret = errno;
}}
0002-sssctl-use-internal-API-to-remove-files.patch
From 6413cb17138d8b24d579109454ae5dd7049b552a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 13:29:54 +0200 Subject: [PATCH 2/2] sssctl: use internal API to remove files
CI passed: http://sssd-ci.duckdns.org/logs/job/50/90/summary.html
ACK (and please add the comment)
bump
New patch is attached. I added a comment a renamed subtree to keep_root_dir.
On 08/09/2016 02:10 PM, Pavel Březina wrote:
On 08/09/2016 01:53 PM, Petr Cech wrote:
On 08/05/2016 01:48 PM, Petr Cech wrote:
On 07/13/2016 01:47 PM, Pavel Březina wrote:
0001-utils-add-remove_subtree.patch
From 0aa39a46b707212e6487b6b537238e31bf7da1b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 12:17:58 +0200 Subject: [PATCH 1/2] utils: add remove_subtree
Remove all entries in a directory but will not remove the directory itself.
^--- [1] ...
- if (!subtree) {
^---
Pavel, please, would you like to add the comment in meaning of [1] here. I needed spent time to understand that the code do what is expected.
ret = unlinkat(parent_fd, dir_name, AT_REMOVEDIR);
if (ret == -1) {
ret = errno;
}}
0002-sssctl-use-internal-API-to-remove-files.patch
From 6413cb17138d8b24d579109454ae5dd7049b552a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 13:29:54 +0200 Subject: [PATCH 2/2] sssctl: use internal API to remove files
CI passed: http://sssd-ci.duckdns.org/logs/job/50/90/summary.html
ACK (and please add the comment)
New patch is attached. I added a comment a renamed subtree to keep_root_dir.
Thanks, Pavel. The new naming is also very useful.
0001-utils-add-remove_subtree.patch
From f94c68ef867327c42d873c508301bfcdc4c66801 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 12:17:58 +0200 Subject: [PATCH 1/2] utils: add remove_subtree
Remove all entries in a directory but will not remove the directory itself.
ack
0002-sssctl-use-internal-API-to-remove-files.patch
From c58d2f6507dda79133813f215c9a4a5feec06d1b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 13:29:54 +0200 Subject: [PATCH 2/2] sssctl: use internal API to remove files
ack
=> ACK
Regards
On Tue, Aug 09, 2016 at 02:49:05PM +0200, Petr Cech wrote:
On 08/09/2016 02:10 PM, Pavel Březina wrote:
On 08/09/2016 01:53 PM, Petr Cech wrote:
On 08/05/2016 01:48 PM, Petr Cech wrote:
On 07/13/2016 01:47 PM, Pavel Březina wrote:
0001-utils-add-remove_subtree.patch
From 0aa39a46b707212e6487b6b537238e31bf7da1b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 12:17:58 +0200 Subject: [PATCH 1/2] utils: add remove_subtree
Remove all entries in a directory but will not remove the directory itself.
^--- [1] ...
- if (!subtree) {
^---
Pavel, please, would you like to add the comment in meaning of [1] here. I needed spent time to understand that the code do what is expected.
ret = unlinkat(parent_fd, dir_name, AT_REMOVEDIR);
if (ret == -1) {
ret = errno;
}}
0002-sssctl-use-internal-API-to-remove-files.patch
From 6413cb17138d8b24d579109454ae5dd7049b552a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 13:29:54 +0200 Subject: [PATCH 2/2] sssctl: use internal API to remove files
CI passed: http://sssd-ci.duckdns.org/logs/job/50/90/summary.html
ACK (and please add the comment)
New patch is attached. I added a comment a renamed subtree to keep_root_dir.
Thanks, Pavel. The new naming is also very useful.
0001-utils-add-remove_subtree.patch
From f94c68ef867327c42d873c508301bfcdc4c66801 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 12:17:58 +0200 Subject: [PATCH 1/2] utils: add remove_subtree
Remove all entries in a directory but will not remove the directory itself.
ack
0002-sssctl-use-internal-API-to-remove-files.patch
From c58d2f6507dda79133813f215c9a4a5feec06d1b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Wed, 13 Jul 2016 13:29:54 +0200 Subject: [PATCH 2/2] sssctl: use internal API to remove files
ack
=> ACK
* master: * 9c7e046cc10a834b86457844df3ba810866cad45 * 68f73e56a9b6133f8a9f4b3c0e696df6c30fec91
sssd-devel@lists.fedorahosted.org