URL: https://github.com/SSSD/sssd/pull/248 Author: justin-stephenson Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier Action: opened
PR body: """ This patch is piggyback
This patch improves the log message to be more information for the SSSD user troubleshooting issues.
If the IDM POSIX group used for AD trust HBAC/SUDO operation is missing the ipaNTSecurityIdentifier it can cause client s2n operations failures resolving the group which resulted in the inability to login for the AD user. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/248/head:pr248 git checkout pr248
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297100893
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297100901
URL: https://github.com/SSSD/sssd/pull/248 Author: justin-stephenson Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier Action: edited
Changed field: body Original value: """ This patch is piggyback
This patch improves the log message to be more information for the SSSD user troubleshooting issues.
If the IDM POSIX group used for AD trust HBAC/SUDO operation is missing the ipaNTSecurityIdentifier it can cause client s2n operations failures resolving the group which resulted in the inability to login for the AD user. """
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
pbrezina commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297310590
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
pbrezina commented: """ Nack. `attrs->a.name` is set only when `attrs->response_type == RESP_NAME` which is not always true here. """
See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297312715
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
pbrezina commented: """ Using just local variable `name` seems to be a better idea, but please check if it is always initialized. """
See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297313544
URL: https://github.com/SSSD/sssd/pull/248 Author: justin-stephenson Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/248/head:pr248 git checkout pr248
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
justin-stephenson commented: """ Thank you for the review, patch updated. """
See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297458904
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
jhrozek commented: """ By the way is the first patch where we added this message OK or does it need the same treatment as well? """
See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297544535
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
justin-stephenson commented: """ I think the patch from **PR 242** is okay. This patch is inside the very large `ipa_s2n_save_objects` function containing a case statement performing conditional code based on the value of `attrs->response_type`. As I understand it, this can lead to `attrs->a.name` not being set in certain cases. """
See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297547990
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
pbrezina commented: """ Ack. """
See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297671375
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
lslebodn commented: """ master: * 0c5f463e9629ac08d647c70cffb30bccdd57ae96 """
See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297933322
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/248 Author: justin-stephenson Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/248/head:pr248 git checkout pr248
sssd-devel@lists.fedorahosted.org