URL: https://github.com/SSSD/sssd/pull/5416 Author: sumit-bose Title: #5416: fp: fix original fix use-after-free - 1.16 version Action: opened
PR body: """ This should have been a cherry-pick of 3b158934cbb8f87cbfaf1650389b8dcd654b92ca but the cherry-pick of the original patch was broken and placed the change into a different function.
This patch fixes this by directly placing the change at the right place.
Resolves: https://github.com/SSSD/sssd/issues/5382 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5416/head:pr5416 git checkout pr5416
URL: https://github.com/SSSD/sssd/pull/5416 Title: #5416: fp: fix original fix use-after-free - 1.16 version
alexey-tikhonov commented: """
This patch fixes this by directly placing the change at the right place.
I would add "... and reverting previous broken cherry-pick" :)
IIUC, original cherry-pick shouldn't even compile... @pbrezina, how do you think, does it make sense / is it possible to run PR CI for 1-16 branch automatically if this label is set on PR against master?
ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/5416#issuecomment-732367100
URL: https://github.com/SSSD/sssd/pull/5416 Title: #5416: fp: fix original fix use-after-free - 1.16 version
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5416 Title: #5416: fp: fix original fix use-after-free - 1.16 version
pbrezina commented: """
This patch fixes this by directly placing the change at the right place.
I would add "... and reverting previous broken cherry-pick" :)
IIUC, original cherry-pick shouldn't even compile...
If so, this is the first time the patch applied cleanly but wrongly :-(
@pbrezina, how do you think, does it make sense / is it possible to run PR CI for 1-16 branch automatically if this label is set on PR against master?
It wouldn't be straightforward but I think doable. But perhaps it would be better to open 1.16 PR after the one for master is accepted and disregard this label completely?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5416#issuecomment-733023508
URL: https://github.com/SSSD/sssd/pull/5416 Title: #5416: fp: fix original fix use-after-free - 1.16 version
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5416 Title: #5416: fp: fix original fix use-after-free - 1.16 version
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5416
* `sssd-1-16` * 1b523ba2a6bfba6974c9c909d6180590d16cc6bd - fp: fix original fix use-after-free - 1.16 version
"""
See the full comment at https://github.com/SSSD/sssd/pull/5416#issuecomment-733622104
URL: https://github.com/SSSD/sssd/pull/5416 Title: #5416: fp: fix original fix use-after-free - 1.16 version
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5416 Title: #5416: fp: fix original fix use-after-free - 1.16 version
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5416 Title: #5416: fp: fix original fix use-after-free - 1.16 version
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5416 Author: sumit-bose Title: #5416: fp: fix original fix use-after-free - 1.16 version Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5416/head:pr5416 git checkout pr5416
URL: https://github.com/SSSD/sssd/pull/5416 Title: #5416: fp: fix original fix use-after-free - 1.16 version
alexey-tikhonov commented: """
@pbrezina, how do you think, does it make sense / is it possible to run PR CI for 1-16 branch automatically if this label is set on PR against master?
It wouldn't be straightforward but I think doable. But perhaps it would be better to open 1.16 PR after the one for master is accepted and disregard this label completely?
Yes, taking into account we do not plan massive updates for 1-16, it doesn't worth the effort to automate this, agree. """
See the full comment at https://github.com/SSSD/sssd/pull/5416#issuecomment-733642527
sssd-devel@lists.fedorahosted.org