ehlo,
macro PAM_DATA_REPLACE isn't available in openpam.
This part was introduced in commit dba7903ba7fc04bc331004b0453938c116be3663 "PAM: close socket fd with pam_set_data"
simple patch is attached.
LS
On Sat, 2014-05-17 at 19:33 +0200, Lukas Slebodnik wrote:
ehlo,
macro PAM_DATA_REPLACE isn't available in openpam.
Are you testing sssd on another OS? If so, do you want any of these patches to be pushed to 1.11 as well before the 1.11.6 release?
This part was introduced in commit dba7903ba7fc04bc331004b0453938c116be3663 "PAM: close socket fd with pam_set_data"
simple patch is attached.
LS
The place you ifdef-ed was the only one where PAM_DATA_REPLACE was used. Not having the macro means the fd would always be closed which sounds like the right thing to do.
ACK
On Sun, 2014-05-18 at 05:32 +0200, Jakub Hrozek wrote:
On Sat, 2014-05-17 at 19:33 +0200, Lukas Slebodnik wrote:
ehlo,
macro PAM_DATA_REPLACE isn't available in openpam.
Are you testing sssd on another OS? If so, do you want any of these patches to be pushed to 1.11 as well before the 1.11.6 release?
This part was introduced in commit dba7903ba7fc04bc331004b0453938c116be3663 "PAM: close socket fd with pam_set_data"
simple patch is attached.
LS
The place you ifdef-ed was the only one where PAM_DATA_REPLACE was used. Not having the macro means the fd would always be closed which sounds like the right thing to do.
ACK
master: a4b2352c97053c79fd0d78d0dd647beed69b17e5
On (18/05/14 05:32), Jakub Hrozek wrote:
On Sat, 2014-05-17 at 19:33 +0200, Lukas Slebodnik wrote:
ehlo,
macro PAM_DATA_REPLACE isn't available in openpam.
Are you testing sssd on another OS? If so, do you want any of these patches to be pushed to 1.11 as well before the 1.11.6 release?
Yes, I would like to push patches to 1.11 branch.
LS
On Mon, May 19, 2014 at 07:53:40AM +0200, Lukas Slebodnik wrote:
On (18/05/14 05:32), Jakub Hrozek wrote:
On Sat, 2014-05-17 at 19:33 +0200, Lukas Slebodnik wrote:
ehlo,
macro PAM_DATA_REPLACE isn't available in openpam.
Are you testing sssd on another OS? If so, do you want any of these patches to be pushed to 1.11 as well before the 1.11.6 release?
Yes, I would like to push patches to 1.11 branch.
sssd-1-11: 13e0c411b3106663399ca9fcd79c55ae10276873
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Jakub Hrozek -
Lukas Slebodnik