-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
There is no need to pass "domain" as a parameter to the data provider. We're already talking directly to the provider for that domain. Both the provider and responder are fully aware of which domain is being queried without passing this parameter. It only serves to complicate the interface.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/22/2010 10:14 AM, Stephen Gallagher wrote:
There is no need to pass "domain" as a parameter to the data provider. We're already talking directly to the provider for that domain. Both the provider and responder are fully aware of which domain is being queried without passing this parameter. It only serves to complicate the interface.
Simo noticed a typo on this patch during code review. Fixed.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/22/2010 05:34 PM, Stephen Gallagher wrote:
Simo noticed a typo on this patch during code review. Fixed.
* providers/data_provider.h:67 still mentions "domains" in the PAM response packet * I'm not sure about removing pd->domain from pam_print_data(). It is still used elsewhere in the code (via the DEBUG_PAM_DATA() macro)
Otherwise looks good to me.
Ack to the other (DP registration) patch.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/22/2010 12:19 PM, Jakub Hrozek wrote:
On 02/22/2010 05:34 PM, Stephen Gallagher wrote:
Simo noticed a typo on this patch during code review. Fixed.
- providers/data_provider.h:67 still mentions "domains" in the PAM
response packet
Fixed
- I'm not sure about removing pd->domain from pam_print_data(). It is
still used elsewhere in the code (via the DEBUG_PAM_DATA() macro)
Ah, thanks. I removed that because I was originally going to remove pd->domain from the pam_ctx struct, but I decided to leave it around. I forgot to put it back into pam_print_data().
Otherwise looks good to me.
New patch attached.
Ack to the other (DP registration) patch.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/22/2010 06:30 PM, Stephen Gallagher wrote:
New patch attached.
Ack
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/22/2010 12:44 PM, Jakub Hrozek wrote:
On 02/22/2010 06:30 PM, Stephen Gallagher wrote:
New patch attached.
Ack
Pushed both to master. - -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Stephen Gallagher