URL: https://github.com/SSSD/sssd/pull/5357 Author: akuster Title: #5357: Provide missing defines which otherwise are available on glibc system… Action: opened
PR body: """ … headers
Signed-off-by: Armin Kuster akuster808@gmail.com """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5357/head:pr5357 git checkout pr5357
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system…
alexey-tikhonov commented: """ Hi,
what system/toolchain miss this? """
See the full comment at https://github.com/SSSD/sssd/pull/5357#issuecomment-705637335
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system…
akuster commented: """ Musl in the OpenEmbedded build framework """
See the full comment at https://github.com/SSSD/sssd/pull/5357#issuecomment-705648319
URL: https://github.com/SSSD/sssd/pull/5357 Author: akuster Title: #5357: Provide missing defines which otherwise are available on glibc system… Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5357/head:pr5357 git checkout pr5357
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system…
akuster commented: """ sure thing. V2 on its way """
See the full comment at https://github.com/SSSD/sssd/pull/5357#issuecomment-705945474
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system…
alexey-tikhonov commented: """ Well, it seems this is [widespread approach](https://patchwork.openembedded.org/patch/161531/) to fix this issue while building against Musl. I wonder why it can't be included in Musl instead...
Nonetheless, taking into account `util/util.h` includes `sys/stat.h`, I think this patch is not dangerous. But I will let other to provide an opinion as well.
(Perhaps it makes sense to add a source code comment with a note why we might need to define this (build against musl)) """
See the full comment at https://github.com/SSSD/sssd/pull/5357#issuecomment-706045059
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system…
alexey-tikhonov commented: """ Well, it seems this is [widespread approach](https://patchwork.openembedded.org/patch/161531/) to fix this issue while building against Musl. I wonder why it can't be included in Musl instead...
Nonetheless, taking into account `util/util.h` includes `sys/stat.h`, I think this patch is not dangerous. But I will let others to provide an opinion as well.
(Perhaps it makes sense to add a source code comment with a note why we might need to define this (build against musl)) """
See the full comment at https://github.com/SSSD/sssd/pull/5357#issuecomment-706045059
URL: https://github.com/SSSD/sssd/pull/5357 Author: akuster Title: #5357: Provide missing defines which otherwise are available on glibc system... Action: edited
Changed field: title Original value: """ Provide missing defines which otherwise are available on glibc system… """
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system...
sumit-bose commented: """ Hi,
while a I agree that the proper fix might be on the musl side I'm fine with including this patch.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5357#issuecomment-769080875
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system...
alexey-tikhonov commented: """ ACK """
See the full comment at https://github.com/SSSD/sssd/pull/5357#issuecomment-769088052
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system...
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system...
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system...
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5357
* `master` * b0edc83e3e70b4dc62d89e4ea1c53911b703250b - Provide missing defines which otherwise are available on glibc system headers
"""
See the full comment at https://github.com/SSSD/sssd/pull/5357#issuecomment-769684084
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system...
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system...
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5357 Title: #5357: Provide missing defines which otherwise are available on glibc system...
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5357 Author: akuster Title: #5357: Provide missing defines which otherwise are available on glibc system... Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5357/head:pr5357 git checkout pr5357
sssd-devel@lists.fedorahosted.org