On 04/22/2014 09:55 AM, Lukas Slebodnik wrote:
ehlo,
attached patch fixes errors on RHEL6
LS
I had these errors on Fedora 17 and 19 as well. The patch fixes them for me.
But since the macros are taken from check's source code, wouldn't it be appropriate to put reference into the code? Something like /* These macros were taken from check's project source files. * http://check.sourceforge.net/ */
Otherwise the patch is OK.
Thanks, Michal
On (23/04/14 23:38), Michal Židek wrote:
On 04/22/2014 09:55 AM, Lukas Slebodnik wrote:
ehlo,
attached patch fixes errors on RHEL6
LS
I had these errors on Fedora 17 and 19 as well. The patch fixes them for me.
But since the macros are taken from check's source code, wouldn't it be appropriate to put reference into the code? Something like /* These macros were taken from check's project source files.
*/
Comment was added.
Otherwise the patch is OK.
Thank you for review.
New version is attached.
LS
On 04/24/2014 09:37 AM, Lukas Slebodnik wrote:
On (23/04/14 23:38), Michal Židek wrote:
On 04/22/2014 09:55 AM, Lukas Slebodnik wrote:
ehlo,
attached patch fixes errors on RHEL6
LS
I had these errors on Fedora 17 and 19 as well. The patch fixes them for me.
But since the macros are taken from check's source code, wouldn't it be appropriate to put reference into the code? Something like /* These macros were taken from check's project source files.
*/
Comment was added.
Otherwise the patch is OK.
Thank you for review.
New version is attached.
LS
Ack.
Michal
On Thu, Apr 24, 2014 at 01:48:19PM +0200, Michal Židek wrote:
On 04/24/2014 09:37 AM, Lukas Slebodnik wrote:
On (23/04/14 23:38), Michal Židek wrote:
On 04/22/2014 09:55 AM, Lukas Slebodnik wrote:
ehlo,
attached patch fixes errors on RHEL6
LS
I had these errors on Fedora 17 and 19 as well. The patch fixes them for me.
But since the macros are taken from check's source code, wouldn't it be appropriate to put reference into the code? Something like /* These macros were taken from check's project source files.
*/
Comment was added.
Otherwise the patch is OK.
Thank you for review.
New version is attached.
LS
Ack.
Michal
Pushed to master: 1a94716209e40a9ccaedc7e70f9de961d1cced48
On Fri, Apr 25, 2014 at 10:34:21AM +0200, Jakub Hrozek wrote:
On Thu, Apr 24, 2014 at 01:48:19PM +0200, Michal Židek wrote:
On 04/24/2014 09:37 AM, Lukas Slebodnik wrote:
On (23/04/14 23:38), Michal Židek wrote:
On 04/22/2014 09:55 AM, Lukas Slebodnik wrote:
ehlo,
attached patch fixes errors on RHEL6
LS
I had these errors on Fedora 17 and 19 as well. The patch fixes them for me.
But since the macros are taken from check's source code, wouldn't it be appropriate to put reference into the code? Something like /* These macros were taken from check's project source files.
*/
Comment was added.
Otherwise the patch is OK.
Thank you for review.
New version is attached.
LS
Ack.
Michal
Pushed to master: 1a94716209e40a9ccaedc7e70f9de961d1cced48
Also pushed to sssd-1-11: b5fdc61e88bec3498e26430b2ddbec6c2206dabc
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Lukas Slebodnik -
Michal Židek