On Fri, Nov 09, 2012 at 09:14:16AM -0500, Simo Sorce wrote:
On Fri, 2012-11-09 at 09:00 +0100, Jakub Hrozek wrote:
> On Thu, Nov 08, 2012 at 02:19:57PM -0500, Simo Sorce wrote:
> > On Thu, 2012-11-08 at 20:09 +0100, Jakub Hrozek wrote:
> > > I noticed that if offline auth failed for any reason including
> > > mistyped
> > > password, we would always print System Error. This makes auditing the
> > > logs hard as it sounds like an internal error occured.
> > >
> > > I don't like the header with a single inline function myself, but I
> > > didn't want to clutter util.h with that function either. And we
> > > have any shared header for that purpose at the moment..suggestions are
> > > welcome.
> > >
> > Any reason why you want an inline here and not use a normal function in
> > util.c ?
> It's a simple switch, pretty much just a setter. There's no logic in the
> function, not even a local variable.
Sure, but as you said it is a bit ugly to have inlines in headers,
however I have nothing against if this is just a temporary thing until
we properly address error returns,
Yes, I noted that in a comment of
so you get my ack either way.
Pushed to master and sssd-1-9