URL: https://github.com/SSSD/sssd/pull/827 Author: alexey-tikhonov Title: #827: ldap/sdap_idmap.c: removed unnecessary include Action: opened
PR body: """
"""
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/827/head:pr827 git checkout pr827
URL: https://github.com/SSSD/sssd/pull/827 Author: alexey-tikhonov Title: #827: ldap/sdap_idmap.c: removed unnecessary include Action: edited
Changed field: body Original value: """
"""
URL: https://github.com/SSSD/sssd/pull/827 Title: #827: ldap/sdap_idmap.c: removed unnecessary include
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/827 Title: #827: ldap/sdap_idmap.c: removed unnecessary include
jhrozek commented: """ Ci passed, no reason to not ack the patch """
See the full comment at https://github.com/SSSD/sssd/pull/827#issuecomment-501813153
URL: https://github.com/SSSD/sssd/pull/827 Title: #827: ldap/sdap_idmap.c: removed unnecessary include
mzidek-rh commented: """ Just to give more context I got from Alexey over IRC. He did this as part of his FIPS work. It is better to avoid including security related header files or files that may look like they enable some security functions to files where they are not needed because we may need to explain why they are there.
So the patch makes sense IMO. I will run some checks and ack if everything is OK. """
See the full comment at https://github.com/SSSD/sssd/pull/827#issuecomment-501813518
URL: https://github.com/SSSD/sssd/pull/827 Title: #827: ldap/sdap_idmap.c: removed unnecessary include
mzidek-rh commented: """ Ok, jakub already ran the CI, so all green :) """
See the full comment at https://github.com/SSSD/sssd/pull/827#issuecomment-501813744
URL: https://github.com/SSSD/sssd/pull/827 Title: #827: ldap/sdap_idmap.c: removed unnecessary include
mzidek-rh commented: """ Ok, jakub already ran the CI, so all green :)
Edit: or it was probably just the automatic PR CI run, in any case, green is green :) """
See the full comment at https://github.com/SSSD/sssd/pull/827#issuecomment-501813744
URL: https://github.com/SSSD/sssd/pull/827 Title: #827: ldap/sdap_idmap.c: removed unnecessary include
jhrozek commented: """ * master: 2a5cc368e62dfeac6214ad5e9cffecc9c7f608e9 """
See the full comment at https://github.com/SSSD/sssd/pull/827#issuecomment-501825414
URL: https://github.com/SSSD/sssd/pull/827 Author: alexey-tikhonov Title: #827: ldap/sdap_idmap.c: removed unnecessary include Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/827/head:pr827 git checkout pr827
URL: https://github.com/SSSD/sssd/pull/827 Title: #827: ldap/sdap_idmap.c: removed unnecessary include
Label: +Pushed
sssd-devel@lists.fedorahosted.org