Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
On (18/04/17 03:47), fidencio wrote:
On Tue, Apr 18, 2017 at 11:33 AM, lslebodn
> Removing unit test is not acceptable without writing new one.
Maybe I wasn't clear enough in the "NSS/TESTS: Improve non-fqnames tests"
I do NOT remove any test per si.
The situation before was:
- I was using the very same setup() function and setting subdomain->fqnames
Then it would be good to have common_setup function
or call one setup function from another + additional modifications.
The current situation is:
- Now I set subdomain->fqnames = false in the newly introduced setup()
function, which allows me to use the tests from where I copied, pasted and
changed the code to set subdomain->fqnames = false.
It is not just about `subdomain->fqnames = false`
There are more changes between `test_nss_getgrnam_members_subdom`
-void test_nss_getgrnam_members_subdom(void **state)
+void test_nss_getgrnam_members_subdom_nonfqnames(void **state)
+ nss_test_ctx->subdom->fqnames = false;
And you removed valid test case without equivalent replacement.
See the full comment at https://github.com/SSSD/sssd/pull/235#issuecomment-294812283