Hello,
while working on #2332 I found these 2 bugs. Unfortunately they weren't the cause of problem, but bugs anyway.
Please see attached patches.
Pavel Reichl
On Mon, Apr 28, 2014 at 10:07:55AM +0200, Pavel Reichl wrote:
Hello,
while working on #2332 I found these 2 bugs. Unfortunately they weren't the cause of problem, but bugs anyway.
Please see attached patches.
Pavel Reichl
From 111cf406d01e228f9097aa4bff6d8ceac1992db6 Mon Sep 17 00:00:00 2001 From: Pavel Reichl preichl@redhat.com Date: Fri, 25 Apr 2014 13:26:19 +0100 Subject: [PATCH] AD Provider: bug-fix uninitialized variable
Resolves: https://fedorahosted.org/sssd/ticket/2332
src/providers/ad/ad_subdomains.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/providers/ad/ad_subdomains.c b/src/providers/ad/ad_subdomains.c index abcc93cfae60e8a81d2075c3c275597f79a514e6..7c6848d935983d480407cbdf5051bd663036ef64 100644 --- a/src/providers/ad/ad_subdomains.c +++ b/src/providers/ad/ad_subdomains.c @@ -664,7 +664,7 @@ static void ad_subdomains_get_root_domain_done(struct tevent_req *req) struct sysdb_attrs **reply = NULL; struct ad_subdomains_req_ctx *ctx; int dp_error = DP_ERR_FATAL;
- bool has_changes;
- bool has_changes = false;
As an addition or an alternative I would like to suggest to fix ad_subdomains_refresh() as well so that the last argument is always set if EOK is returned.
bye, Sumit
ctx = tevent_req_callback_data(req, struct ad_subdomains_req_ctx);-- 1.8.4.2
On Mon, 2014-04-28 at 11:00 +0200, Sumit Bose wrote:
On Mon, Apr 28, 2014 at 10:07:55AM +0200, Pavel Reichl wrote:
Hello,
while working on #2332 I found these 2 bugs. Unfortunately they weren't the cause of problem, but bugs anyway.
Please see attached patches.
Pavel Reichl
From 111cf406d01e228f9097aa4bff6d8ceac1992db6 Mon Sep 17 00:00:00 2001 From: Pavel Reichl preichl@redhat.com Date: Fri, 25 Apr 2014 13:26:19 +0100 Subject: [PATCH] AD Provider: bug-fix uninitialized variable
Resolves: https://fedorahosted.org/sssd/ticket/2332
src/providers/ad/ad_subdomains.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/providers/ad/ad_subdomains.c b/src/providers/ad/ad_subdomains.c index abcc93cfae60e8a81d2075c3c275597f79a514e6..7c6848d935983d480407cbdf5051bd663036ef64 100644 --- a/src/providers/ad/ad_subdomains.c +++ b/src/providers/ad/ad_subdomains.c @@ -664,7 +664,7 @@ static void ad_subdomains_get_root_domain_done(struct tevent_req *req) struct sysdb_attrs **reply = NULL; struct ad_subdomains_req_ctx *ctx; int dp_error = DP_ERR_FATAL;
- bool has_changes;
- bool has_changes = false;
As an addition or an alternative I would like to suggest to fix ad_subdomains_refresh() as well so that the last argument is always set if EOK is returned.
bye, Sumit
ctx = tevent_req_callback_data(req, struct ad_subdomains_req_ctx);-- 1.8.4.2
Hello Sumit,
OK, new patches attached.
On (28/04/14 12:48), Pavel Reichl wrote:
On Mon, 2014-04-28 at 11:00 +0200, Sumit Bose wrote:
On Mon, Apr 28, 2014 at 10:07:55AM +0200, Pavel Reichl wrote:
Hello,
while working on #2332 I found these 2 bugs. Unfortunately they weren't the cause of problem, but bugs anyway.
Please see attached patches.
Pavel Reichl
From 111cf406d01e228f9097aa4bff6d8ceac1992db6 Mon Sep 17 00:00:00 2001 From: Pavel Reichl preichl@redhat.com Date: Fri, 25 Apr 2014 13:26:19 +0100 Subject: [PATCH] AD Provider: bug-fix uninitialized variable
Error: Invalid ticket number
Ticket 2332 does not exist.
Which ticket do you mean?
LS
On Mon, 2014-04-28 at 14:19 +0200, Lukas Slebodnik wrote:
On (28/04/14 12:48), Pavel Reichl wrote:
On Mon, 2014-04-28 at 11:00 +0200, Sumit Bose wrote:
On Mon, Apr 28, 2014 at 10:07:55AM +0200, Pavel Reichl wrote:
Hello,
while working on #2332 I found these 2 bugs. Unfortunately they weren't the cause of problem, but bugs anyway.
Please see attached patches.
Pavel Reichl
From 111cf406d01e228f9097aa4bff6d8ceac1992db6 Mon Sep 17 00:00:00 2001 From: Pavel Reichl preichl@redhat.com Date: Fri, 25 Apr 2014 13:26:19 +0100 Subject: [PATCH] AD Provider: bug-fix uninitialized variable
Error: Invalid ticket number
Ticket 2332 does not exist.
Which ticket do you mean?
LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
I meant #2322. After discussion with Lukas I decided to remove ticket label from commit message in 1st patch as this was probably not related to this issue.
But I fixed the number in the 2nd patch, which although does not solve the ticket is closely relevant.
On Mon, Apr 28, 2014 at 02:47:11PM +0200, Pavel Reichl wrote:
On Mon, 2014-04-28 at 14:19 +0200, Lukas Slebodnik wrote:
On (28/04/14 12:48), Pavel Reichl wrote:
On Mon, 2014-04-28 at 11:00 +0200, Sumit Bose wrote:
On Mon, Apr 28, 2014 at 10:07:55AM +0200, Pavel Reichl wrote:
Hello,
while working on #2332 I found these 2 bugs. Unfortunately they weren't the cause of problem, but bugs anyway.
Please see attached patches.
Pavel Reichl
From 111cf406d01e228f9097aa4bff6d8ceac1992db6 Mon Sep 17 00:00:00 2001 From: Pavel Reichl preichl@redhat.com Date: Fri, 25 Apr 2014 13:26:19 +0100 Subject: [PATCH] AD Provider: bug-fix uninitialized variable
Error: Invalid ticket number
Ticket 2332 does not exist.
Which ticket do you mean?
LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
I meant #2322. After discussion with Lukas I decided to remove ticket label from commit message in 1st patch as this was probably not related to this issue.
But I fixed the number in the 2nd patch, which although does not solve the ticket is closely relevant.
ACK
bye, Sumit
On Tue, Apr 29, 2014 at 11:57:36AM +0200, Sumit Bose wrote:
On Mon, Apr 28, 2014 at 02:47:11PM +0200, Pavel Reichl wrote:
On Mon, 2014-04-28 at 14:19 +0200, Lukas Slebodnik wrote:
On (28/04/14 12:48), Pavel Reichl wrote:
On Mon, 2014-04-28 at 11:00 +0200, Sumit Bose wrote:
On Mon, Apr 28, 2014 at 10:07:55AM +0200, Pavel Reichl wrote:
Hello,
while working on #2332 I found these 2 bugs. Unfortunately they weren't the cause of problem, but bugs anyway.
Please see attached patches.
Pavel Reichl
From 111cf406d01e228f9097aa4bff6d8ceac1992db6 Mon Sep 17 00:00:00 2001 From: Pavel Reichl preichl@redhat.com Date: Fri, 25 Apr 2014 13:26:19 +0100 Subject: [PATCH] AD Provider: bug-fix uninitialized variable
Error: Invalid ticket number
Ticket 2332 does not exist.
Which ticket do you mean?
LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
I meant #2322. After discussion with Lukas I decided to remove ticket label from commit message in 1st patch as this was probably not related to this issue.
But I fixed the number in the 2nd patch, which although does not solve the ticket is closely relevant.
ACK
bye, Sumit
Pushed to master: cef2384a3a6fc1a1637c6a55e2bced93d28e8fca ed61bfc5184d9c7a46d17681a22a1abb64423708
and sssd-1-11: 7344bde2d0995a3295b2bea2d347ed1926cbdf2d a392c0870e4a4dfc476ec00b0d7cb454b37c8833
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Lukas Slebodnik -
Pavel Reichl -
Sumit Bose